Correct length in sharding #2262
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to change in #2023, "activation_length" definition changed. Specifically, "expert" is added there, and causing some conflicts:
1. For conflicting combination "activation_batch" + "activation_length" in file. Either update to "activation_length_no_exp" or "activation_norm_length".
2. For conflicting combination "activation_embed_and_logits_batch", "activation_length", we can restore old definition by using "activation_length_no_exp"
FIXES: b/441547754
1 Changes related to "activation_batch"
TSP should use "activation_norm_length" for decoder block
TSP should use "activation_length_no_exp" for MLP and MoE
Additional changes
2 Changes related to "activation_embed_and_logits_batch"
train.py, decoder.py, embedding.py: restore to "activation_length_no_exp"
Tests
N/A
Checklist
Before submitting this PR, please make sure (put X in square brackets):