Skip to content

minor fixes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamBalski merged 1 commit into from
Oct 13, 2025
Merged

minor fixes #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/tic_tac_toe/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def state(self) -> GameState:
# todo
return GameState.UNFINISHED
def are_coordinates_valid(self, coordinates: typing.Tuple[int, int]):
return 0 < coordinates[0] < 3 and 0 < coordinates[1] < 3
return 0 <= coordinates[0] < 3 and 0 <= coordinates[1] < 3
def at_coordinates(self, coordinates: typing.Tuple[int, int]):
return self.board[coordinates[0]][coordinates[1]]

Expand All @@ -37,19 +37,18 @@ def print_state(state: State):
print("Draw")
case 4:
print("Unfinished")
msg = " a b c" + "\n".join(str(index+1) + " " + " ".join(row) for index,row in enumerate(state.board))
print(msg
)
msg = " a b c\n" + "\n".join(str(index+1) + " " + " ".join(row) for index,row in enumerate(state.board))
print(msg)
def ask_for_row():
alphabet = ["1", "2", "3"]
result = None
while len(result := input("Specify column")) != 1 or result not in alphabet:
while len(result := input("Specify row(1, 2 or 3): ")) != 1 or result not in alphabet:
print("Need one character (1, 2 or 3)")
return ord(result) - 65
return ord(result) - 49
def ask_for_column():
alphabet = ["A", "B", "C"]
result = None
while len(result := input("Specify column")) != 1 or result not in alphabet:
while len(result := input("Specify column(A, B or C): ")) != 1 or result not in alphabet:
print("Need one character (A, B or C)")
return ord(result) - 65
def ask_for_coordinates():
Expand Down