libafl_nyx: Build qemu/packer in target directory #3534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Nyx build process to build QEMU and packer components in the Cargo target directory instead of the source directory. This helps keep build artifacts organized and separated from source code.
Key Changes:
- Updated
build.rsto determine the target directory fromOUT_DIRand pass it to the build script - Modified
build_nyx_support.shto accept a target directory parameter and build components there - Updated the sed command to reference
Makefile.libxdcfrom the script directory instead of a relative path
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/libafl_nyx/build.rs | Calculates target directory path and passes it as an argument to the build script |
| crates/libafl_nyx/build_nyx_support.sh | Accepts target directory parameter, creates it, and builds QEMU/packer there; updates sed command to use absolute path for Makefile.libxdc |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.