Merged
Conversation
…eceiving-period-count Change MaximumProfitReceivingPeriodCount
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)99.75%[contract/AElf.Contracts.Profit/ProfitContract.cs] 98.55%[protobuf/profit_contract.proto] 94.02%[contract/AElf.Contracts.Profit/ProfitContractState.cs] 82.34%[contract/AElf.Contracts.Profit/ProfitContractConstants.cs] 96.75%[contract/AElf.Contracts.Profit/ViewMethods.cs] 97.34%[...test/AElf.Contracts.Election.Tests/Full/ReleaseProfitsFro] 98.73%[test/AElf.Contracts.Profit.Tests/ProfitTests.cs] 70.80%[...test/AElf.Contracts.Profit.Tests/ProfitContractTestConsta] |
jason-aelf
approved these changes
Feb 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3526 +/- ##
==========================================
+ Coverage 90.66% 90.69% +0.03%
==========================================
Files 663 663
Lines 25458 25500 +42
Branches 2285 2287 +2
==========================================
+ Hits 23082 23128 +46
+ Misses 2260 2256 -4
Partials 116 116
|
Stephen02Zhang
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3527