Skip to content

Fix: improve semantic accuracy#3494

Merged
jason-aelf merged 5 commits intorelease/1.6.1from
fix/modify-issuer-owner
Dec 9, 2023
Merged

Fix: improve semantic accuracy#3494
jason-aelf merged 5 commits intorelease/1.6.1from
fix/modify-issuer-owner

Conversation

@kaiwenzhengaelf
Copy link
Contributor

No description provided.

…rAndOwnerModificationDisabled and adjust GetTokenIssuerAndOwnerModificationEnabled return value
@vizipi
Copy link

vizipi bot commented Dec 8, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % EanCuznaivy 250 4
100.00 % jason-hoopox 23 4
100.00 % gldeng 19 4
100.00 % ZhangXin 15 4
100.00 % Stephen02Zhang 1 4
100.00 % zhifenglee-portkey 1 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs90.32 %28 out of 31 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT87.10 %27 out of 31 times
...contract/AElf.Contracts.CrossChain/CrossChainContract_Hel83.87 %26 out of 31 times
contract/AElf.Contracts.MultiToken/TokenContract_Views.cs80.65 %25 out of 31 times
contract/AElf.Contracts.Economic/EconomicContract.cs80.65 %25 out of 31 times
...contract/AElf.Contracts.Election/ElectionContract_Elector80.65 %25 out of 31 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio80.65 %25 out of 31 times
test/AElf.Contracts.TestBase/ContractTester.cs77.42 %24 out of 31 times
contract/AElf.Contracts.Profit/ProfitContract.cs77.42 %24 out of 31 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs74.19 %23 out of 31 times

Committed file ranks

(click to expand)
  • 98.80%[...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication]
  • 99.98%[contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs]
  • 99.96%[protobuf/token_contract.proto]
  • 97.33%[protobuf/token_contract_impl.proto]
  • @codecov
    Copy link

    codecov bot commented Dec 8, 2023

    Codecov Report

    Merging #3494 (3a0445d) into release/1.6.1 (c910c95) will increase coverage by 0.07%.
    The diff coverage is 100.00%.

    Additional details and impacted files

    Impacted file tree graph

    @@                Coverage Diff                @@
    ##           release/1.6.1    #3494      +/-   ##
    =================================================
    + Coverage          90.59%   90.66%   +0.07%     
    =================================================
      Files                663      663              
      Lines              25455    25458       +3     
      Branches            2285     2285              
    =================================================
    + Hits               23061    23082      +21     
    + Misses              2278     2260      -18     
      Partials             116      116              
    Files Coverage Δ
    ...AElf.Contracts.MultiToken/TokenContract_Actions.cs 95.74% <100.00%> (+3.88%) ⬆️

    @vizipi vizipi bot requested a review from arg-foo December 9, 2023 12:48
    @jason-aelf jason-aelf merged commit c391774 into release/1.6.1 Dec 9, 2023
    @delete-merged-branch delete-merged-branch bot deleted the fix/modify-issuer-owner branch December 9, 2023 13:22
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants