Skip to content

fix(application): remove matching on name for members list check#1331

Merged
WikiRik merged 5 commits intostablefrom
fix-is-on-memberslist
Mar 12, 2025
Merged

fix(application): remove matching on name for members list check#1331
WikiRik merged 5 commits intostablefrom
fix-is-on-memberslist

Conversation

@LeonVreling
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.87%. Comparing base (7716c8a) to head (3e1bf6f).
Report is 1 commits behind head on stable.

❗ There is a different number of reports uploaded between BASE (7716c8a) and HEAD (3e1bf6f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (7716c8a) HEAD (3e1bf6f)
4 1
Additional details and impacted files
@@             Coverage Diff             @@
##           stable    #1331       +/-   ##
===========================================
- Coverage   98.47%   61.87%   -36.60%     
===========================================
  Files          38       38               
  Lines        2230     2227        -3     
  Branches      446      443        -3     
===========================================
- Hits         2196     1378      -818     
- Misses         30      700      +670     
- Partials        4      149      +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we leave the current test cases and only update the assertion and title? I think they might still be valid test cases of behaviour that we don't want changed

@LeonVreling
Copy link
Member Author

I don't really see the need for testing both case sensitive and case insensitive tbh if we are not testing the matching anymore, but it can be re-added

@WikiRik
Copy link
Member

WikiRik commented Mar 12, 2025

I don't really see the need for testing both case sensitive and case insensitive tbh if we are not testing the matching anymore, but it can be re-added

I would prefer that, just to be safe

@LeonVreling LeonVreling requested a review from WikiRik March 12, 2025 15:08
@WikiRik WikiRik merged commit 97168ed into stable Mar 12, 2025
5 checks passed
@WikiRik WikiRik deleted the fix-is-on-memberslist branch March 12, 2025 16:12
serge1peshcoff pushed a commit that referenced this pull request Mar 12, 2025
## [1.14.2](1.14.1...1.14.2) (2025-03-12)

### Bug Fixes

* **application:** remove matching on name for members list check ([#1331](#1331)) ([97168ed](97168ed))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.14.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

WikiRik pushed a commit to AEGEE/MyAEGEE that referenced this pull request Jan 18, 2026
## [1.14.2](AEGEE/statutory@1.14.1...1.14.2) (2025-03-12)

### Bug Fixes

* **application:** remove matching on name for members list check ([#1331](AEGEE/statutory#1331)) ([97168ed](AEGEE/statutory@97168ed))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants