Skip to content

Support for variable number of walkers in WepyHDF5 #34

Open

Description

@salotz-sitx

There is some basic considerations towards this, but a more thorough audit needs to be done to make sure that this is supported in a first class way.

Currently, if the number of walkers increases a new "trajectory" is added and in the trajectory group metadata a field is added noting which cycle it was created.

Activity

  1. salotz-sitx commented on Sep 15, 2021

    @salotz-sitx
    ContributorAuthor

    The first approach was to hack this into the "sparse fields" feature.

    Options to make all fields sparse for variable number simulations was added (PR forthcoming).

    This mostly works but is broken wrt mandatory "fields" i.e. weights. The proper solution then is support a dataset under each trajectory of _cycle_idxs and then _sparse_idxs for each field is relative to that. This allows for them both to coexist, which was a problem with the sparse fields for variable number of walkers hack.

  2. added this to the 2.0 Release milestone on Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions