Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1deg_jra55do_iaf: update OM3 executable to latest version #22

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

micaeljtoliveira
Copy link
Contributor

Changes needed to use latest OM3 executable.

Contributes to COSIMA/access-om3#118

@micaeljtoliveira micaeljtoliveira added the 1deg_jra55do_iaf 1deg_jra55do_iaf configuration label Apr 5, 2024
@micaeljtoliveira
Copy link
Contributor Author

Unfortunately this currently does not run. It crashes with the following error:

 *** WAVEWATCH III ERROR IN W3IOGR :
     UNEXPECTED SOURCE TERM IDENTIFIER 3
          IN mod_def.ww3 FILE : Ice sink term (Wang and Shen) 
    EXPECTED FROM switch FILE : ------------------------------
     MOD DEF FILE WAS GENERATED WITH A DIFFERENT            
     WW3 VERSION OR USING A DIFFERENT SWITCH FILE.          
     MAKE SURE WW3_GRID IS COMPILED WITH SAME SWITCH        
     AS WW3_SHEL OR WW3_MULTI, RUN WW3_GRID AGAIN           
     AND THEN TRY AGAIN THE PROGRAM YOU JUST USED.          

@ezhilsabareesh8 Do you know how to fix this?

@dougiesquire
Copy link
Collaborator

Yeah, I think this configuration is currently broken for the current switches - see #17

@micaeljtoliveira
Copy link
Contributor Author

Thanks. Shall we then simply merge this as is, without testing? Or leave it open or now?

@ezhilsabareesh8
Copy link

ezhilsabareesh8 commented Apr 5, 2024

Hi @micaeljtoliveira , the executables needs to be updated in the bin directory to match the mod_def files. The following executable of the WW3_switches branch needs to be added to the bin directory.

@micaeljtoliveira
Copy link
Contributor Author

micaeljtoliveira commented Apr 5, 2024

@ezhilsabareesh8 I'm using spack to build and install the executables, not the build.sh script. With Spack all gets properly installed:

$ ls /g/data/ik11/spack/0.21.2/opt/linux-rocky8-cascadelake/intel-2021.10.0/access-om3-main-6pue372/bin/
access-om3-CICE6-WW3  access-om3-MOM6-CICE6  access-om3-MOM6-CICE6-WW3  ww3_grid  ww3_ounf  ww3_ounp  ww3_outf  ww3_strt

Edit: the latest version of the build.sh script uses cmake --install to install the executables (see here), so also the WW3 utilities should be installed correctly.

@ezhilsabareesh8
Copy link

ezhilsabareesh8 commented Apr 5, 2024

@micaeljtoliveira This branch 1deg_jra55do_iaf_iss118 is compatible only with the WW3_switches access-om3 build, the changes are not pushed to access-om3 main branch since we are in the process of finalising switches for wave attenuation and dissipation model

@micaeljtoliveira
Copy link
Contributor Author

Ah, okay. Then I think it's best to leave this open until you're done with updating the switches.

@micaeljtoliveira micaeljtoliveira marked this pull request as draft April 5, 2024 04:30
@ezhilsabareesh8
Copy link

I have created a pull request in access-om3, I think we can merge these changes to access-om3 main since current IC3 switch works reasonably well and we can modify the switches later if needed.

@micaeljtoliveira micaeljtoliveira changed the title 1deg jra55do iaf iss118 1deg_jra55do_iaf: update OM3 executable to latest version Apr 8, 2024
@micaeljtoliveira
Copy link
Contributor Author

@ezhilsabareesh8 I've now tried to run this branch with the OM3 version that includes the changes from COSIMA/access-om3#131, but I still get the same error.

As we have also updated the WW3 version in OM3, don't we need to regenerate the mod_def files?

… using a spack built executable, all dependencies are handled through rpath and we can leave payu to figure out whatever is missing.
@ezhilsabareesh8
Copy link

As we have also updated the WW3 version in OM3, don't we need to regenerate the mod_def files?

Hi @micaeljtoliveira, yes mod_def files need to be generated with the new executables, I did that and copied it to ik11 inputs directory. It should work now.

@micaeljtoliveira
Copy link
Contributor Author

@ezhilsabareesh8 Thanks! Seems to work correctly now.

@micaeljtoliveira micaeljtoliveira marked this pull request as ready for review April 18, 2024 06:28
@ezhilsabareesh8
Copy link

ezhilsabareesh8 commented Apr 18, 2024

However, I found something weird from the wav.log, the input file ww3_shel.nml is completely ignored and no input field is being passed or output is requested with the current executable.


  Input fields :
 --------------------------------------------------
       ice param. 1   ---/NO
       ice param. 2   ---/NO
       ice param. 3   ---/NO
       ice param. 4   ---/NO
       ice param. 5   ---/NO
       mud density    ---/NO
       mud thkness    ---/NO
       mud viscos.    ---/NO
       water levels   ---/NO
       currents       ---/NO
       winds          ---/NO
       ice fields     ---/NO
       momentum       ---/NO
       air density    ---/NO
       mean param.    ---/NO
       1D spectra     ---/NO
       2D spectra     ---/NO

            Fields   : no fields defined

@micaeljtoliveira
Copy link
Contributor Author

@ezhilsabareesh8 I suggest we merge this nevertheless, and fix any remaining issue in a different PR.

@ezhilsabareesh8
Copy link

@ezhilsabareesh8 I suggest we merge this nevertheless, and fix any remaining issue in a different PR.

Sounds good to me, I am looking into this issues, will open a separate PR

@ezhilsabareesh8
Copy link

This PR can be closed, I opened a separate issue #143 to address the changes with updated WW3 component.

Copy link

@ezhilsabareesh8 ezhilsabareesh8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The updated OM3 executable is working and the compatible mod_def.ww3 and restart.ww3 are added to ik11/inputs/ directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1deg_jra55do_iaf 1deg_jra55do_iaf configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants