-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1deg_jra55do_iaf: update OM3 executable to latest version #49
Conversation
… using a spack built executable, all dependencies are handled through rpath and we can leave payu to figure out whatever is missing.
This crashes for me as is when trying to read datm files:
|
@dougiesquire Weird. Could you check the result of |
|
Runs fine for me. Any changes in the manifests when you run? |
Ah shoot, sorry - I was picking up old restarts from another run. Damn you Payu! I can run this fine. |
metadata.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you commit this file by accident?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoyingly, new Payu automatically commits this file if it doesn't exist / gets updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was automatically added by payu. Damn you Payu!
I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we request an option to not commit this? (Maybe there is one already?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we request an option to not commit this?
Yes. I would say it should not do it automatically when runlog: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we can disable the metadata.yaml
stuff by setting in the config.yaml
:
metadata:
enable: False
I've opened an issue here to add this to configs while we're still developing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good to know, thanks!
The only downside is that we will now have two flags in the configs that users need to revert for production: metadata
and runlog
.
On the other hand, I would have expected payu to honor the value of `runlog' and not commit anything to the git repo. Also because there might be an interest in generating the metadata file, but not committing it.
@aidanheerdegen What do you think?
757f58f
to
ede5866
Compare
|
Busted! We are (I am) just blaming Payu for our own incompetence |
Changes needed to use latest OM3 executable.
Contributes to COSIMA/access-om3#118