Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1deg_jra55do_iaf: update OM3 executable to latest version #49

Merged
merged 3 commits into from
Apr 5, 2024
Merged

1deg_jra55do_iaf: update OM3 executable to latest version #49

merged 3 commits into from
Apr 5, 2024

Conversation

micaeljtoliveira
Copy link
Contributor

Changes needed to use latest OM3 executable.

Contributes to COSIMA/access-om3#118

@micaeljtoliveira
Update field dictionary.
ddfb2cc
@micaeljtoliveira
Update OM3 executable to use.
0a4e6fc
@micaeljtoliveira
Remove environment modules stuff from config.yaml. Because we are now…
ede5866 
… using a spack built executable, all dependencies are handled through rpath and we can leave payu to figure out whatever is missing.
@micaeljtoliveira micaeljtoliveira added the 1deg_jra55do_iaf 1deg_jra55do_iaf configuration label Apr 5, 2024
@micaeljtoliveira micaeljtoliveira changed the title Update OM3 executable to latest version 1deg_jra55do_iaf: update OM3 executable to latest version Apr 5, 2024
@dougiesquire
Copy link
Collaborator

This crashes for me as is when trying to read datm files:

 ERROR: ERROR reading in nfiles
Image              PC                Routine            Line        Source
access-om3-MOM6-C  00000000004DFF91  shr_abort_mod_mp_         114  shr_abort_mod.F90
access-om3-MOM6-C  00000000048C7DEA  dshr_stream_mod_m        1890  dshr_stream_mod.F90
access-om3-MOM6-C  00000000048D984B  dshr_mod_mp_dshr_        1022  dshr_mod.F90
access-om3-MOM6-C  000000000489BDA4  datm_datamode_jra         317  datm_datamode_jra55do_mod.F90
access-om3-MOM6-C  000000000487B137  atm_comp_nuopc_mp         671  atm_comp_nuopc.F90
access-om3-MOM6-C  000000000487E2E8  atm_comp_nuopc_mp         493  atm_comp_nuopc.F90
access-om3-MOM6-C  0000000000E14374  _ZN5ESMCI6FTable1        2167  ESMCI_FTable.C
access-om3-MOM6-C  0000000000E184AA  ESMCI_FTableCallE         824  ESMCI_FTable.C
access-om3-MOM6-C  0000000001B3E8AF  _ZN5ESMCI3VMK5ent        2321  ESMCI_VMKernel.C
access-om3-MOM6-C  000000000220FCB2  _ZN5ESMCI2VM5ente        1216  ESMCI_VM.C
access-om3-MOM6-C  0000000000E157B7  c_esmc_ftablecall         981  ESMCI_FTable.C
access-om3-MOM6-C  0000000000BD5A81  esmf_compmod_mp_e        1223  ESMF_Comp.F90
access-om3-MOM6-C  00000000012CA299  esmf_gridcompmod_        1412  ESMF_GridComp.F90
access-om3-MOM6-C  0000000000AE7A58  nuopc_driver_mp_l        2886  NUOPC_Driver.F90
access-om3-MOM6-C  0000000000ACFE55  nuopc_driver_mp_i        1979  NUOPC_Driver.F90
access-om3-MOM6-C  0000000000E14374  _ZN5ESMCI6FTable1        2167  ESMCI_FTable.C
access-om3-MOM6-C  0000000000E184AA  ESMCI_FTableCallE         824  ESMCI_FTable.C
access-om3-MOM6-C  0000000001B3E8AF  _ZN5ESMCI3VMK5ent        2321  ESMCI_VMKernel.C
access-om3-MOM6-C  000000000220FCB2  _ZN5ESMCI2VM5ente        1216  ESMCI_VM.C
access-om3-MOM6-C  0000000000E157B7  c_esmc_ftablecall         981  ESMCI_FTable.C
access-om3-MOM6-C  0000000000BD5A81  esmf_compmod_mp_e        1223  ESMF_Comp.F90
access-om3-MOM6-C  00000000012CA299  esmf_gridcompmod_        1412  ESMF_GridComp.F90
access-om3-MOM6-C  0000000000AE7A58  nuopc_driver_mp_l        2886  NUOPC_Driver.F90
access-om3-MOM6-C  0000000000AD00A8  nuopc_driver_mp_i        1984  NUOPC_Driver.F90
access-om3-MOM6-C  0000000000A94CAD  nuopc_driver_mp_i         484  NUOPC_Driver.F90
access-om3-MOM6-C  0000000000E14374  _ZN5ESMCI6FTable1        2167  ESMCI_FTable.C
access-om3-MOM6-C  0000000000E184AA  ESMCI_FTableCallE         824  ESMCI_FTable.C
access-om3-MOM6-C  0000000001B3E8AF  _ZN5ESMCI3VMK5ent        2321  ESMCI_VMKernel.C
access-om3-MOM6-C  000000000220FCB2  _ZN5ESMCI2VM5ente        1216  ESMCI_VM.C
access-om3-MOM6-C  0000000000E157B7  c_esmc_ftablecall         981  ESMCI_FTable.C
access-om3-MOM6-C  0000000000BD5A81  esmf_compmod_mp_e        1223  ESMF_Comp.F90
access-om3-MOM6-C  00000000012CA299  esmf_gridcompmod_        1412  ESMF_GridComp.F90
access-om3-MOM6-C  0000000000432ABF  MAIN__                    128  esmApp.F90
access-om3-MOM6-C  000000000043248D  Unknown               Unknown  Unknown
libc-2.28.so       0000152BAC5BED85  __libc_start_main     Unknown  Unknown
access-om3-MOM6-C  00000000004323AE  Unknown               Unknown  Unknown

@micaeljtoliveira
Copy link
Contributor Author

@dougiesquire Weird. Could you check the result of module use? Does it have the "old" spack instance (/g/data/ik11/spack/0.20.1/modules/access-om3/0.x.0/)?

@dougiesquire
Copy link
Collaborator 

$ module use
Search path for module files (in search order):
  /g/data/vk83/modules
  /etc/scl/modulefiles
  /opt/Modules/modulefiles
  /opt/Modules/v4.3.0/modulefiles
  /apps/Modules/modulefiles

@micaeljtoliveira
Copy link
Contributor Author

Runs fine for me. Any changes in the manifests when you run?

@dougiesquire
Copy link
Collaborator

Ah shoot, sorry - I was picking up old restarts from another run. Damn you Payu!

I can run this fine.

anton-seaice
anton-seaice reviewed Apr 5, 2024
View reviewed changes
metadata.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you commit this file by accident?

Copy link
Collaborator

@dougiesquire dougiesquire Apr 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoyingly, new Payu automatically commits this file if it doesn't exist / gets updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was automatically added by payu. Damn you Payu!

I'll remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we request an option to not commit this? (Maybe there is one already?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we request an option to not commit this?

Yes. I would say it should not do it automatically when runlog: false

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can disable the metadata.yaml stuff by setting in the config.yaml:

metadata:
  enable: False

I've opened an issue here to add this to configs while we're still developing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to know, thanks!

The only downside is that we will now have two flags in the configs that users need to revert for production: metadata and runlog.

On the other hand, I would have expected payu to honor the value of `runlog' and not commit anything to the git repo. Also because there might be an interest in generating the metadata file, but not committing it.

@aidanheerdegen What do you think?

@micaeljtoliveira micaeljtoliveira merged commit de4a6c5 into 1deg_jra55do_iaf Apr 5, 2024
@micaeljtoliveira micaeljtoliveira deleted the 1deg_jra55do_iaf_iss118 branch April 5, 2024 04:01
@aidanheerdegen
Copy link
Member

payu is coming in for a lot of stick. If there are problems please do create issues @micaeljtoliveira @dougiesquire (or comment on existing ones to highlight they need addressing).

@dougiesquire
Copy link
Collaborator

dougiesquire commented Apr 16, 2024 •
edited
Loading

payu is coming in for a lot of stick

Busted! We are (I am) just blaming Payu for our own incompetence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougiesquire dougiesquire dougiesquire approved these changes

@anton-seaice anton-seaice anton-seaice approved these changes

Assignees
No one assigned
Labels
1deg_jra55do_iaf 1deg_jra55do_iaf configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micaeljtoliveira @dougiesquire @aidanheerdegen @anton-seaice