Improve time gap error messages with diagnostic detail#551
Merged
Conversation
When time bounds are not contiguous, include the index, surrounding timestamps, and mismatched bound values (up to 5 examples) so the source of the gap is immediately visible in the error output. For frequency-fallback gaps, show the actual timestamps bracketing each invalid interval instead of just the day-length numbers. Adds _describe_bounds_gaps() static helper; _time_bounds_have_gaps() interface is unchanged (tests unaffected).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
- Coverage 74.9% 74.8% -0.0%
=======================================
Files 36 36
Lines 7156 7191 +35
Branches 1333 1340 +7
=======================================
+ Hits 5357 5381 +24
- Misses 1519 1525 +6
- Partials 280 285 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When time bounds continuity checks fail, the error message previously gave no indication of where in the time axis the problem was.
Before
After
For the frequency-fallback path, intervals now show the surrounding timestamps instead of just the day counts:
Changes
_describe_bounds_gaps()static helper that identifies discontinuous bound indices and formats them with surrounding time coordinate values (up to 5 shown)_time_bounds_have_gaps()interface unchanged — existing tests unaffected(t_before, t_after, delta_days)so timestamps appear in the error message