Change qc range to raise warnings instead of raising error#550
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
=====================================
Coverage 74.9% 74.9%
=====================================
Files 36 36
Lines 7156 7156
Branches 1333 1333
=====================================
Hits 5357 5357
Misses 1519 1519
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the behavior of the
_check_rangemethod to emit warnings instead of raising errors when variable values fall outside the valid range. Corresponding tests have been updated to expect warnings rather than exceptions.Core logic changes:
_check_rangeinsrc/access_moppy/base.pyto usewarnings.warn(withUserWarning) instead of raisingValueErrorwhen values are out of the specified range.Test updates:
tests/unit/test_base.pyto check for warnings (usingpytest.warns) instead of errors (usingpytest.raises) for both below-minimum and above-maximum value cases. Test names and docstrings were updated to reflect the new warning behavior.tests/unit/test_base_loading_chunker.pyto expect warnings instead of errors for out-of-range values, and updated the docstring accordingly. [1] [2]