forked from GOG-Nebula/galaxy-integration-steam
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac build fix #11
Open
bgebhardt
wants to merge
111
commits into
ABaumher:master
Choose a base branch
from
bgebhardt:mac_build_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mac build fix #11
Changes from 1 commit
Commits
Show all changes
111 commits
Select commit
Hold shift + click to select a range
9ef4340
Add protobuff files
LauraRozier 029e695
Add (improvised) missing files
LauraRozier 98e3444
Update bindings
LauraRozier e0b914f
Fix AttributeError('out_of_game_heartbeat_seconds')
LauraRozier cb9f8c3
Update README.md
TheSentry 0d24e8a
implemented the RSA call.
ABaumher 4f39c71
actually staging the changes this time, lol
ABaumher 4edb254
Updated enums to the current version available. Continued modificatio…
ABaumher d0c2a14
Updated protocol buffer message files to work with auth. Merged chang…
ABaumher 0b16bfc
updated the EMsg constants. They were out of date
ABaumher 77474d5
minor changes to protobuf client. Prototyping new workflow. Preparing…
ABaumher 6cc7ecb
Updated bugfixes to a version that runs in GOG Galaxy. This still req…
ABaumher b61273b
Got the RSA Key all the way back to the Backend, so we can change the…
ABaumher 58c8f29
Update that gets the password RSA key for the user. Implements the ba…
ABaumher 7498c57
Maybe breaking. Looking for an old message i wrote, so i need this ba…
ABaumher da90375
updated consts, protobuf, protocol buffer to report modern os types (…
ABaumher 83a69a1
Testing various changes. This will break at some point before hitting…
ABaumher 76ccfca
Breaking Change: Renamed types.py so Visual Studio would stop complai…
ABaumher 708083c
adding type hints, mostly. need to track down where job_list was adde…
ABaumher 141eed8
Public Key data comes back in hexidecimal, so that is now handled pro…
ABaumher 0eef845
Full login with no SteamGuard test. Likely will require a few bugfixe…
ABaumher dc762dd
Login processed properly, goes to confirm to get the tokens, and none…
ABaumher 0285aa2
Merged in Thibmo's fixes and proto files. this is not a complete merg…
ABaumher 4429a71
Dealing with getting the proto files properly parsed and built so the…
ABaumher 3cd0b49
Added Protos. Updated Tasks.py to properly import them. They still do…
ABaumher 91f2670
Reverted py files to what they were before merging with Thibmo's fork.
ABaumher 95bbacf
Updated the protobuf list to the files we currently use. There are a …
ABaumher f65f179
Figured out how to handle conflicts with the service messages. we sho…
ABaumher e4cf9bd
Finally found the version of protoc the old version was using. we can…
ABaumher a44be78
Updates throughout the code base. Preparing for full auth workflow an…
ABaumher a135724
Full integration of all parts of new auth flow implemented. Bugfixing…
ABaumher d9641f3
Bugs Fixed. Now logs in, but no other messages are sent. needs a Clie…
ABaumher 0d50163
Experimental branch; i don't want to break something on the main fix.…
ABaumher 7922c28
Added a readme for alpha testers
ABaumher 452d83a
Update README_ALPHA.md
ABaumher dc6adcd
Attempt to fix issue raised by HiddenAnomaly
ABaumher d008b6c
preparing to call old client login method. preparing to remove public…
ABaumher 825de45
Merge branch 'remove_public_profiles_backend' into AuthFix
ABaumher 5869ef9
Finished removing public profiles. Started adding the token login cal…
ABaumher 81e3a66
Fixed a few issues created by removing public backend
ABaumher f506150
Getting persistent login to work. Fixed a few errors.
ABaumher b8f9a0e
Removed logger info for packet information. This massively bloated th…
ABaumher 0bcaf03
fix mobile confirm flow. not pretty but should work
8946473
Enable job processing - achievements, collections, game times
slo 6f1aa9e
Merge pull request #1 from don-de-marco/AuthFix
ABaumher 398c39d
bugfix. trying to stay logged in. failing. Currently, the stay logged…
ABaumher ad838f2
disabled cache login. Wrote comments explaining it
ABaumher e45d0e5
Temporary "fix" that removes the job_list so the code will work again.
ABaumher a656d12
Persistent login now works.
ABaumher 167aa0f
Remove guard data requirements, as they were breaking mobile login
ABaumher fe25334
(try to) fix the conflicting protobuf files situation
33908dc
fix proto2 syntax statement
46c3370
Bugfix to properly recover when refresh token expires or is revoked.
ABaumher 921bd72
Update README_ALPHA.md
ABaumher 6869909
Update README_ALPHA.md
ABaumher 7f01fc0
Update README_ALPHA.md
ABaumher d75bf9c
Update README_ALPHA.md
ABaumher 4647e5f
Update README_ALPHA.md
ABaumher 5805697
Update README.md
ABaumher 8521a9b
Update protobuf_steammessages.txt
ABaumher 86a709e
Merge pull request #1 from don-de-marco/abaumher-rebase
ABaumher 6aa370d
Update README.md
ABaumher 9873e50
Update README.md
ABaumher e0a78a1
Update README.md
ABaumher 374dbd2
added install.txt so readme works properly
ABaumher e0a00a5
Update the install so it works properly. Merge changes that i didn't …
ABaumher 04ff339
Fix the readme and install.txt so they now work
ABaumher 7b23678
Actually fixed it this time. Requires galaxy plugin in install
ABaumher 3b7c90e
Added beautiful soup to app requirements so it does not crash. fixed …
ABaumher 9435073
revert app.txt change. remove user_profile, which caused the conflict…
ABaumher e511960
Bugfix so mobile code works correctly
ABaumher 3f242fe
updated translate error to log the error received so we can more easi…
ABaumher 8cfb1c4
bugfix for mobile confirm. If you hit continue before confirming, it …
ABaumher bc8af72
Reverted UI so it's user and password. cleaned up the css and html so…
ABaumher 6d5e8e3
fixes multiple bugs: a residual debug that caused errors on a failed …
ABaumher 4247b66
missed a pair of errors related to removing user name from pages.
ABaumher cb6f315
Mobile confirm bugfix, html now displays errors properly.
ABaumher 050f9e1
Attempting to refactor all the code to work with mobile confirm. I st…
ABaumher 45d450b
fallback on mobile confirm should now work.
ABaumher 4b3f3ff
Bugfixes (again). Email code works again.
ABaumher 1ede3a7
Tracked down a bug where the client would silently crash if you revok…
ABaumher 276cabe
bugfix, priority list was sorting ascending, wanted descending.
ABaumher 37762fd
Multiple bugfixes. Mobile confirm should finally work (though, probab…
ABaumher 50ceaab
Bugfix. Wrapping recv in a task was done improperly. it's now fixed. …
ABaumher c8b8a7b
Updated the ui for mobile confirm for clarity. link now uses the prop…
ABaumher bb47e90
Experiemental Resend Code implementation. Two Factor expire now kicks…
ABaumher 9e226de
Revert "Updated the ui for mobile confirm for clarity. link now uses …
ABaumher e2d6f6c
Revert "Experiemental Resend Code implementation. Two Factor expire n…
ABaumher 23423d9
Reverts all the changes made to try to fix the resend issue. We now j…
ABaumher b68aff8
Merge pull request #4 from ABaumher/revert_pls
ABaumher cd5133a
hopefully fixed error message for login page after a timeout
ABaumher 05a1615
Updated index with a message explaining what happens when email times…
ABaumher a137cd5
some fixes to readme, move pip req to reqs file, fix start of pytest
MisterZeus 30369f8
Merge pull request #5 from ABaumher/mobile_confirm_refactor
ABaumher 236ab56
Update README.md
ABaumher f93ea59
Update README.md
ABaumher 9c700b7
Merge branch 'master' into master
MisterZeus 489230c
check whether users have py installed
MisterZeus 3aa2cfa
Merge branch 'master' of https://github.com/MisterZeus/galaxy-integra…
MisterZeus a51a0fc
remove exeprobe, make if simpler
MisterZeus 23ef0c0
readme tweaks
MisterZeus 3a03a84
Merge pull request #3 from MisterZeus/master
ABaumher eb8879b
Update gitignore to ignore zip files, so it excudes the release. reim…
ABaumher 432e77c
Temporary fix for achievements sync. Limit simultaneous jobs.
wwMRd 3da5c06
Merge pull request #8 from wwMRd/achievements_temp_fix
ABaumher 5231719
Added .DStore to ignore list
bgebhardt e3bb216
Revert "Added .DStore to ignore list"
bgebhardt 6a253d0
Added mac-related .dot files
bgebhardt 9ab4a60
updated required pip-tools
bgebhardt dbd6f45
Updated mac build instructions
bgebhardt 33d791d
Added instructions to setup protobuf compiling on Mac
bgebhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Added instructions to setup protobuf compiling on Mac
- Loading branch information
commit 33d791d73e021cae657108db2df8a9f02771fb63
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,3 +22,22 @@ Updating the compiled protobuf files is just as easy as the following steps: | |
|
||
* <https://github.com/steamdatabase/protobufs> | ||
* <https://github.com/ValvePython/steam> | ||
|
||
## Installing and generating protobufs on Mac | ||
|
||
First time Install Python OpenSSL Certificates so the request library can pull Stream protobufs. | ||
|
||
1. Install python 3.7 from https://www.python.org/downloads/. It puts Python in your Applications directory | ||
2. `"/Applications/Python 3.7/Install Certificates.command"` You must install for Python 3.7. | ||
|
||
The README instructions have you set up a virtual environment but for some reason `inv PullProtobufSteamMessages` looks for the certicicates in the "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/" directory, so you need both. | ||
|
||
See info in [python - urllib.error.URLError: <urlopen error \[SSL: CERTIFICATE_VERIFY_FAILED\] certificate verify failed: unable to get local issuer certificate (_ssl.c:1108) - Stack Overflow](https://stackoverflow.com/questions/68275857/urllib-error-urlerror-urlopen-error-ssl-certificate-verify-failed-certifica#:~:text=Here%20are%20the%20steps%20for%20macOS%3A%20Open%20the,had%20to%20do%20this%20twice%20before%20it%20worked.) | ||
|
||
Now you can run `inv PullProtobufSteamMessages` which will download and replace the protobufs checked into git. | ||
|
||
To regenerate protobufs you must get and install the protobuf compiler. | ||
|
||
1. `inv InstallProtoc` | ||
2. `chmod a+x protoc/bin/protoc` # the InstallProtoc task does not set the protoc to be executable | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have hopefully made this part of the install protoc call. See https://github.com/ABaumher/galaxy-integration-steam/blob/MacOS_Fix/tasks.py#L151-L152 |
||
3. `inv GenerateProtobufMessages` will now work. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully i can just install
certifi
and it'll work. This is done in https://github.com/ABaumher/galaxy-integration-steam/blob/MacOS_Fix/requirements/install.txt#L13 and https://github.com/ABaumher/galaxy-integration-steam/blob/MacOS_Fix/requirements/app.txt#L7