Skip to content

Update to MTP - #109

Merged
AArnott merged 1 commit into
AArnott:mainfrom
Youssef1313:mtp
May 20, 2026
Merged

AArnott merged 1 commit into
AArnott:mainfrom
Youssef1313:mtp

Conversation

@Youssef1313

Copy link
Copy Markdown
Contributor

This PR updates the repo to use Microsoft.Testing.Platform instead of VSTest. This works with xunit 2 thanks via YTest.MTP.XUnit2 (package that I own - not maintained by xUnit.net or Microsoft).

@Youssef1313
Youssef1313 force-pushed the mtp branch 2 times, most recently from b384e17 to aa475b7 Compare January 1, 2026 16:26
@AArnott

AArnott commented Jan 1, 2026

Copy link
Copy Markdown
Owner

oh! Very interesting. This is not the only xunit v2 extension that thus far hasn't moved to MTP for its own internal tests because of the apparent incompatibility. I'll be curious to learn more about how this is achieved.
I may want to rearrange the xml slightly to match what's in Library.Template to avoid merge conflicts down the road as well.

It looks like you're still working on it so I'll hold off reviewing for a while.

Thanks for contributing, @Youssef1313!

@Youssef1313

Youssef1313 commented Jan 1, 2026 •

Copy link
Copy Markdown
Contributor Author

oh! Very interesting. This is not the only xunit v2 extension that thus far hasn't moved to MTP for its own internal tests because of the apparent incompatibility. I'll be curious to learn more about how this is achieved.

In simple terms, YTest.MTP.XUnit2 implements an MTP test framework based on the public xunit 2 APIs that allows to run/discover tests. https://github.com/Youssef1313/YTest.MTP.XUnit2/blob/190d316dd771469e4b7b7375d9e351d321df1b9e/src/YTest.MTP.XUnit2/MTPFramework/XUnit2MTPTestFramework.cs is the ITestFramework implementation that I register, and the core logic for reporting test results is in https://github.com/Youssef1313/YTest.MTP.XUnit2/blob/190d316dd771469e4b7b7375d9e351d321df1b9e/src/YTest.MTP.XUnit2/XUnitSinks/MTPExecutionSink.cs

I may want to rearrange the xml slightly to match what's in Library.Template to avoid merge conflicts down the road as well.

It looks like Directory.Packages.props is already not in sync with the current one in Library.Template.

It looks like you're still working on it so I'll hold off reviewing for a while.

It should be green (hopefully) on the current state. I had to update the cloud test script though, which is diverging from Library.Template. It's unfortunate that MTP filtering isn't standardized (xunit.v3 chose to do their own filter command-line options, while MSTest/NUnit keeps the same syntax of the VSTest filter, etc). So as of today, there is unfortunately no way for the cloud test script to do filtering correctly in a way that will be correct for all test frameworks. This will also be quite big problem for solutions that are mixing multiple test frameworks. I opened microsoft/testfx#7160 which I will discuss with the team once I'm back from vacation (or probably a little bit after - depending on the priorities).

@AArnott
AArnott merged commit 94281af into AArnott:main May 20, 2026
4 checks passed
CurtHagenlocher pushed a commit to adbc-drivers/hiveserver2 that referenced this pull request Aug 24, 2026
Updated
[Xunit.SkippableFact](https://github.com/AArnott/Xunit.SkippableFact)
from 1.5.61 to 1.5.85.

<details>
<summary>Release notes</summary>

_Sourced from [Xunit.SkippableFact's
releases](https://github.com/AArnott/Xunit.SkippableFact/releases)._

## 1.5.85

## What's Changed

* Add release package code signing by @​AArnott in
AArnott/Xunit.SkippableFact#148
* Preserve test output for dynamically skipped tests by @​AArnott in
AArnott/Xunit.SkippableFact#149

## New Contributors
* @​Youssef1313 made their first contribution in
AArnott/Xunit.SkippableFact#109

**Full Changelog**:
AArnott/Xunit.SkippableFact@v1.5.61...v1.5.85

Commits viewable in [compare
view](AArnott/Xunit.SkippableFact@v1.5.61...v1.5.85).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Xunit.SkippableFact&package-manager=nuget&previous-version=1.5.61&new-version=1.5.85)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants