Repository navigation
perf: bail out when an impossible pairwise tuple cannot be covered - #225
Merged
Merged
Conversation
When CreateRandomTestCase returns null, FindAllowedTestCase has already exhausted every completion of the selected tuple. Continuing the seven attempt maximization loop only repeats that expensive search. Return null immediately, matching the same fix applied in TUnit's PairwiseStrategy.
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When exclusions make a selected pairwise tuple unreachable,
CreateRandomTestCasereturnsnullafterFindAllowedTestCasehas already searched every completion of that tuple. The maximization loop then repeated that search up to six more times with no chance of success.Return
nullimmediately instead. Same change as reviewed on thomhurst/TUnit#6971.Test plan