Support RTL 🌐 #1
Conversation
| @@ -176,7 +176,7 @@ public void setIconColor(@ColorInt final int color) { | |||
| /** | |||
| * Change drawable icon size | |||
| * | |||
| * @param widthRes Set width resource id | |||
| * @param widthRes Set width resource id | |||
There was a problem hiding this comment.
Sorry, this was auto formatted 🙇
| updateIcons(); | ||
| } else { | ||
| setVectorDrawable(INDEX_LEFT, resourceId); | ||
| } |
There was a problem hiding this comment.
This logic is same in several method so I moved it to setVectorDrawable() method.
| @@ -278,7 +284,7 @@ private static Bitmap drawable2Bitmap(final Drawable drawable, final int iconWid | |||
| * {@link android.content.res.Resources} or a {@link android.content.res.TypedArray}. | |||
| */ | |||
| private static void fixDrawable(@NonNull final Drawable drawable) { | |||
| if (Build.VERSION.SDK_INT == 21 | |||
| if (Build.VERSION.SDK_INT == Build.VERSION_CODES.LOLLIPOP | |||
| Resources resources = getContext().getResources(); | ||
| Locale locale = Build.VERSION.SDK_INT >= Build.VERSION_CODES.N | ||
| ? resources.getConfiguration().getLocales().getFirstMatch(resources.getAssets().getLocales()) | ||
| : resources.getConfiguration().locale; |
There was a problem hiding this comment.
After Android N, configuration.locale became deprecated.
| @@ -0,0 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
JFYI: You might have known.
If you use this chrome plugin, you can see VectorDrawable icon on GitHub page like this. It helps you to review PR.
| android:textColor="#795548" | ||
| android:textSize="@dimen/text_large" | ||
| app:cit_drawableStart="@drawable/ic_language_black_24px" | ||
| app:cit_iconColor="#4E342E" |
There was a problem hiding this comment.
I choosed Brown 500 and 800 here from https://material.io/guidelines/style/color.html
because it reminds me something like Earth 🌍
| @@ -131,4 +133,4 @@ See the License for the specific language governing permissions and | |||
| limitations under the License. | |||
| ``` | |||
|
|
|||
| [preview]: /arts/preview.png | |||
| [preview]: /arts/preview.jpg | |||
There was a problem hiding this comment.
It was too big so I changed the width to 300 px.
|
Thank you so much! 😄 |
|
Thanks for the quick review! 😄 |
Overview
Thanks for the cool library.
This library didn't support RTL attributes such as
drawableStartanddrawableEnd.I added these two in this PR.
cit_drawableStartandcit_drawableEndattributes.setmethods.Screenshot
See the text on the bottom.
Note
This contains a little refactoring. If you don't like it, feel free to comment. Thanks!