Conversation
Revised ShellTemplate.xml with new submodels. Removed shell-template-creator service from docker-compose.yml, so AAS template is no longer auto-created at startup. Updated aas-template-registry image version and adjusted network references. Minor formatting improvements.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Docker Compose–based example setups by removing the runtime “shell-template-creator” container and instead providing the shell template declaratively as an AAS environment XML file that the template repository can load from the mounted ./aas folder.
Changes:
- Removed the
shell-template-creatorservice from both example compose files. - Added
ShellTemplate.xmlAAS environment files for both example setups to define the shell template declaratively. - Minor compose-file formatting adjustments.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| source/AAS.TwinEngine.Plugin.TestPlugin/Example/docker-compose.yml | Removes the curl-based shell template creation service from the test-plugin example compose stack. |
| source/AAS.TwinEngine.Plugin.TestPlugin/Example/aas/ShellTemplate.xml | Adds an XML-defined shell template for the test-plugin example. |
| example/docker-compose.yml | Removes the curl-based shell template creation service from the main example compose stack (plus minor formatting). |
| example/aas/ShellTemplate.xml | Adds an XML-defined shell template for the main example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Test & Coverage ReportTest Results Summary
Code CoverageUnit Tests Coverage
Minimum allowed line rate is Module Tests Coverage
|
mm-asha
approved these changes
Apr 1, 2026
mm-mcn
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the example configuration by removing the unnecessary shell-template-creator service and introducing an XML-based shell template instead.
What Changed
Why This Change
Reduces complexity by eliminating an extra service
Encourages a more declarative and maintainable shell template definition
Aligns the example with the recommended configuration approach
Impact
No functional impact on runtime behavior
Example setup is easier to understand and maintain