Fix doc's mysql create table statement. - #92
Open
gptjddldi wants to merge 1 commit into
Open
Conversation
Collaborator
|
@gptjddldi - There is merge conflict please review and fix. Thanks for your contribution we are happy to accept your submission. |
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation’s MySQL employee table DDL to match the schema that the rest of the “Getting Started” examples use (notably the id, email, and created_on fields referenced in the sample API requests/responses).
Changes:
- Replaced the MySQL
CREATE TABLE employeeexample to useidas the primary key and includeemail+created_on. - Applied the same MySQL DDL update consistently in both the intro and Docker quickstart docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/run-db2rest-on-docker.md | Updates the MySQL table creation snippet to align with the schema used in the walkthrough API examples. |
| docs/intro.mdx | Updates the MySQL table creation snippet to match the PostgreSQL schema and the subsequent request/response examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first time contributing to an open-source project. I might be missing something, so please let me know if anything looks wrong — I’ll be happy to fix it right away.
In your documentation (specifically, the intro and run-db2rest-on-docker), the MySQL table creation syntax seemed different from the PostgreSQL example provided earlier. I updated the MySQL example to make it consistent.
The original MySQL example was:
When using this syntax, the following request failed.:

To resolve the issue, I modified the table definition as below: