-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container build process #832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pcolmer,
Thank you so much for the work on getting 96Boards.org building with the Docker container approach. There are a bunch of redirects removed - are we adding replacements to the routingrules.json file? Other than the redirect comments LGTM :)
BR,
Kyle
No. The redirects were removed because you cannot have the same "source" URL mentioned more than once in a Jekyll site otherwise you end up with the redirect page being created multiple times (once for each destination) and you don't know which destination you'll end up with. That and the fact that we're now using Jekyll Doctor as a pre-build test phase and it refuses to allow a page to be built from multiple sources, which is what the above scenario does. |
Add scripts and other configuration files to allow 96Boards website to be built using the new Dockerised mechanism.
Also fix various links that are now showing up as broken because the build process is more robust :)