Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container build process #832

Merged
merged 10 commits into from
Aug 16, 2019
Merged

Container build process #832

merged 10 commits into from
Aug 16, 2019

Conversation

pcolmer
Copy link
Contributor

@pcolmer pcolmer commented Aug 15, 2019

Add scripts and other configuration files to allow 96Boards website to be built using the new Dockerised mechanism.

Also fix various links that are now showing up as broken because the build process is more robust :)

Copy link
Contributor

@kylekirkby kylekirkby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pcolmer,

Thank you so much for the work on getting 96Boards.org building with the Docker container approach. There are a bunch of redirects removed - are we adding replacements to the routingrules.json file? Other than the redirect comments LGTM :)

BR,

Kyle

@pcolmer
Copy link
Contributor Author

pcolmer commented Aug 16, 2019

@kylekirkby

There are a bunch of redirects removed - are we adding replacements to the routingrules.json file?

No. The redirects were removed because you cannot have the same "source" URL mentioned more than once in a Jekyll site otherwise you end up with the redirect page being created multiple times (once for each destination) and you don't know which destination you'll end up with.

That and the fact that we're now using Jekyll Doctor as a pre-build test phase and it refuses to allow a page to be built from multiple sources, which is what the above scenario does.

@pcolmer pcolmer merged commit eb44014 into master Aug 16, 2019
@pcolmer pcolmer deleted the container-build-process branch August 16, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants