Conversation
|
@CEBATOR Why this app is not available in Russian store? |
|
@BadMachine A few reasons
I might try to upload it to appstore after I finish updating, given that GLP3 license allows that. In the meantime, you can build the app yourself, if you have access to a mac. |
|
@CEBATOR Thanks for your answer! |
8of
left a comment
There was a problem hiding this comment.
- Good PR. Extra ❤️ for using final and private in the right places.
- Make suggested small improvement and I'll merge it.
- About "a bug that will not let the video to play from the start once the playback is finished". Is there a simple option in VLC to loop the video? It would solve the problem for now.
- While we are at it, add credentials to the Readme at the end. Something like
WebM support by [your nick/name and link]will do.
| pod 'Texture', '2.5.1' | ||
| pod 'TUSafariActivity', '1.0.4' | ||
| pod 'YapDatabase', '3.0.2' | ||
| pod 'MobileVLCKit', '~>3.3.0' |
There was a problem hiding this comment.
Let's set the exact version here (without ~>) for stability, for now.
| CODE_SIGN_IDENTITY = "iPhone Developer"; | ||
| "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; | ||
| DEFINES_MODULE = YES; | ||
| DEVELOPMENT_TEAM = Q9324QX3V7; |
| var interactor: VLCPlayerViewOutput! | ||
| var player: VLCMediaPlayer? | ||
|
|
||
| @IBOutlet weak var playerView: UIView! |
There was a problem hiding this comment.
I suggest we mark everything private if we aren't accessing it from outside. Even IBOutlets and IBActions.
|
|
||
| // IBAction | ||
|
|
||
| @IBAction func progressBarWasMoved(_ sender: UISlider) { |
There was a problem hiding this comment.
We can move every private method to a private local extension. Code will be more organized, robust and predictable.
|
|
||
| + (UIAlertController *)webmDeprecatedAlert { | ||
| UIAlertController *alertController = [UIAlertController | ||
| alertControllerWithTitle:NSLS(@"DEPRECATED") |
There was a problem hiding this comment.
We can get rid of "Deprecated" in both localizations as well.
|
Surprisingly, several people asked me lately to finally merge this PR or add WebM support at least somehow. It was an Objective C-only project so far. I decided to leave it that way and ported the code to Objective C. Current video controls implementation is really frustrating. Because of delay after tap. The only control I left is a tap on video view to mute / unmute current video. I'll try to look into the problem later if I'll have time. Maybe, I'll implement full thread playlist for convenient webm threads surfing. Anyway, you pushed the project in the right direction and new credit in README file is well deserved. Cheers! 🙌 |
Background
WEBM support was down for a while, and it's frustrating given that most video content on 2ch is in that exact format. Since iOS has no native support for that format, I had to use VLCKit
What has been done
How to test
TODO (sometimes in the future)