Skip to content

Update 8hobbies/workflows digest to a18577b #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

Update 8hobbies/workflows digest to a18577b #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
lint:
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@951751b0bff51b137e19de492856b6405a1ad610
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@a18577bc6b2ba0ee90caea4c978504a835d07977

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix the problem, add a permissions block to the workflow to explicitly limit the permissions granted to the GITHUB_TOKEN. Since this is a lint job, it likely only needs read access to the repository contents. The best way to fix this is to add a permissions block at the root level of the workflow (before jobs:), specifying contents: read. This ensures that all jobs in the workflow, including those using reusable workflows, will have only the minimum required permissions. Edit .github/workflows/lint.yml to insert the following block after the name: line and before the on: block:

permissions:
  contents: read

No additional imports or definitions are needed.

Suggested changeset 1
.github/workflows/lint.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -14,6 +14,9 @@
 
 name: Lint
 
+permissions:
+  contents: read
+
 on:
   push:
     branches: ["master"]
EOF
@@ -14,6 +14,9 @@

name: Lint

permissions:
contents: read

on:
push:
branches: ["master"]
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ jobs:
permissions:
pages: write
id-token: write
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@951751b0bff51b137e19de492856b6405a1ad610
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@a18577bc6b2ba0ee90caea4c978504a835d07977
with:
doc-path: "docs/build"
2 changes: 1 addition & 1 deletion .github/workflows/publish-dry-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
run:
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@951751b0bff51b137e19de492856b6405a1ad610
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@a18577bc6b2ba0ee90caea4c978504a835d07977

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix the problem, add a permissions block at the top level of the workflow file (just after the name: or before/after the on: block). This block should specify the minimal permissions required for the workflow to function. Since this workflow only delegates to a reusable workflow and does not appear to require any write access, the safest minimal starting point is contents: read. If the reusable workflow requires more, you can adjust accordingly, but starting with contents: read is recommended. The change should be made in .github/workflows/publish-dry-run.yml by inserting the permissions: block after the name: line.

Suggested changeset 1
.github/workflows/publish-dry-run.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/publish-dry-run.yml b/.github/workflows/publish-dry-run.yml
--- a/.github/workflows/publish-dry-run.yml
+++ b/.github/workflows/publish-dry-run.yml
@@ -13,6 +13,8 @@
 # limitations under the License.
 
 name: Publish Dry Run
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -13,6 +13,8 @@
# limitations under the License.

name: Publish Dry Run
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
tags: ["v*"]
jobs:
build:
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@951751b0bff51b137e19de492856b6405a1ad610
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@a18577bc6b2ba0ee90caea4c978504a835d07977
secrets:
npm-auth-token: ${{ secrets.NPM_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
test:
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@951751b0bff51b137e19de492856b6405a1ad610
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@a18577bc6b2ba0ee90caea4c978504a835d07977

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix the problem, add a permissions block to the workflow file. This can be done at the top level (applies to all jobs) or at the job level (applies to a specific job). Since this workflow only defines a single job (test), either location is acceptable, but adding it at the top level is clearer and future-proof. The minimal safe starting point is permissions: {} (no permissions), but if the reusable workflow requires specific permissions, you should grant only those. Since we do not know the exact requirements of the called workflow, the best fix is to add permissions: {} at the top level, just after the name: key and before on:.

Suggested changeset 1
.github/workflows/runtime.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/runtime.yml b/.github/workflows/runtime.yml
--- a/.github/workflows/runtime.yml
+++ b/.github/workflows/runtime.yml
@@ -13,6 +13,7 @@
 # limitations under the License.
 
 name: Runtime
+permissions: {}
 
 on:
   push:
EOF
@@ -13,6 +13,7 @@
# limitations under the License.

name: Runtime
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.