Fix distrobox-enter and distrobox-rm to handle containers that have environment variables shoter than 5 symbols #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvironment variables shorter than 5
|
Fixes #1546 |
softmoth
suggested changes
Oct 5, 2024
There was a problem hiding this comment.
Actually, it's probably better to use the startswith function.
mirkobrombin
approved these changes
Oct 9, 2024
|
Thanks @senioroman4uk for the PR and thanks @mirkobrombin for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was trying to use distrobox with rocm/pytorch:latest I've noticed the following error
It turns out this image has an environmental variable CI=1, that causes an exception when distrobox-enter / distrobox-rm is used with this docker image
Added some additional ifs to the corresponding commands to handle this case