Merged
Conversation
seoyoung-min
requested review from
Eugene-A-01,
Nahyun-Kang,
ParkSohyunee and
kanglocal
|
@seoyoung-min is attempting to deploy a commit to the Eujin Ahn's projects Team on Vercel. A member of the Team first needs to authorize it. |
ParkSohyunee
approved these changes
Jan 19, 2025
Contributor
ParkSohyunee
left a comment
ParkSohyunee
left a comment
There was a problem hiding this comment.
서영님!! 오류를 완벽하게 수정해주셨군요!👍👍 고생많으셨습니다~! LGTM✨✨🥰🥰💕
src/app/list/[listId]/edit/page.tsx
Outdated
Comment on lines
91
to
94
| //데이터 채워넣기 | ||
| useEffect(() => { | ||
| initializeFormValues(); | ||
| }, [listDetailData, categories, user.id]); //gpt: 여기 dependency list에 빼야할 게 있을까? |
Contributor
There was a problem hiding this comment.
🤣🤣 서영님의 고군분투 흔적이 보이네용 👍👍
Contributor
Author
There was a problem hiding this comment.
으악 들켰다!! 이거 지우고 머지하겠습니다 ㅋㅋㅋㅋㅋㅋ
Comment on lines
+64
to
65
| flexShrink: 0, | ||
| }); |
Comment on lines
+73
to
85
| useEffect(() => { | ||
| //---주소에서 title, category 가져오기 | ||
| const title = searchParams?.get('title'); | ||
| const category = searchParams?.get('category'); | ||
| /**TODO: 리스트 상세 '이 타이틀로 리스트 생성에도 encode단계 넣어주기 */ | ||
|
|
||
| if (title) setValue('title', title); | ||
| if (category) { | ||
| setValue('category', categories?.find((c) => c.korName === category)?.engName); | ||
| } | ||
| }, [searchParams, categories]); | ||
|
|
||
| return ( |
Contributor
There was a problem hiding this comment.
서영님, 궁금한 점이 있습니다!
- 주제, 타이틀 인코딩해서 쿼리파라미터로 보내주면 StepOne에서 받을때 디코딩하는 과정이 있나요? 찾아보니 decodeURIComponent 함수도 있는것 같아서요,, 👀
Contributor
Author
There was a problem hiding this comment.
@ParkSohyunee 원래는 말씀해주신 decodeURIComponent 사용해 받으려고 했는데, 인코딩 단계만 추가해주니 디코딩 단계 없이도 충분히 잘 인식이 되더라고요!! 그래서 따로 추가하지는 않았습니다~!
kanglocal
pushed a commit
to kanglocal/ListyWave-front
that referenced
this pull request
Feb 3, 2025
* Fix: step2 순위뱃지, 타이틀인풋 UI 깨짐 수정 * Design: ItemAccordion hr선 색상 변경 * Feat: 요청 주제 클릭 시 자동 제목 입력 추가 * Fix: 리스트 수정 게시 불가 오류 해결 - 의존성 제거 * Chore: 불필요 코멘트 삭제 * Chore: 불필요 주석 삭제
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
작업 사항
참고 사항 (optional)
관련 이슈 (optional)
리뷰어에게