Support Non-Default Namespace for Model Type Export #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaoyaMiyagawa
commented
May 19, 2024
Comment on lines
+44
to
+45
| .split("/") | ||
| .at(-1)!; // get only model name without directory |
Collaborator
Author
There was a problem hiding this comment.
This is to extract History from Common/History, otherwise model:show command becomes like model:show App\\Models\\Common\\Common/History
NaoyaMiyagawa
commented
May 19, 2024
| const routeListCommand = `php artisan route:list ${options.vendorRoutes ? "" : "--except-vendor" | ||
| } --json > ${tmpDir}/route.json`; | ||
| const vendorOption = options.vendorRoutes ? "" : "--except-vendor"; | ||
| const routeListCommand = `php artisan route:list ${vendorOption} --json > ${tmpDir}/route.json`; |
Collaborator
Author
There was a problem hiding this comment.
Just a refactoring
Collaborator
Author
|
Hi @7nohe, I made an attempt to resolve the issue I raised. Let me know if you have any issues or concerns about this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changes
This PR changes the way to specify a model name in
php artisan model:showcommand. This change is inspired from this comment below:model:showcommand laravel/framework#43156 (comment)Meaning, conventionally
model:showcommand was used like this:And moving forward,
model:showcommand will be used like this:Output
Result of
debug.shSample result of output in modular monolith structure: