Change URL behaviour to match W3 spec #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're attempting to make requests to an API that has case sensitive endpoints. The current behaviour of the wrapper does the not match the W3 spec [1] which says that the domain name should be case insensitive, but the endpoint does not need to be case insensitive. The wrapper currently lowercases the entire url.
Tests were added after the lowercase was a thing, so there's no record of why we're lower casing it all. If this is going to break things we can try and get the endpoint fixed instead.
[1] http://stackoverflow.com/questions/7996919/should-url-be-case-sensitive