Remove mutation that was adding extra query params #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh I've just realised I change the wrong test, will fix in a sec |
danhaller
force-pushed
the
fix-posts-with-substituted-urls
branch
from
8e23535 to
12b8c0f
Compare
|
ok, done |
johnjcorcoran
added a commit
that referenced
this pull request
Mar 11, 2016
Remove mutation that was adding extra query params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POST endpoints with parameter substitution e.g. ~/foo/{bar} are not working after v7. The user is told that query string parameters cannot be used in combination with payloads, even if the parameter is substituted into the url.
I tracked this down to unintentional mutation in the RequestBuilder.BuildOAuthHeader method, which was adding the substitution parameters back in to the query string parameters after they had been removed.
I've fixed the mutation and renamed a couple of variables to make it a little clearer.