Skip to content

Conversation

@ghiscoding
Copy link
Collaborator

we shouldn't show the Cell Selection drag handle, unless we are using the new Hybrid Selection Model ("mixed" or "cell", but not "row"), it's also unusable unless we are in the hybrid mode, so no reason to show it if it ain't usable

image

@ghiscoding ghiscoding merged commit aa63977 into master Nov 21, 2025
3 checks passed
@ghiscoding ghiscoding deleted the bugfix/hide-drag-handle branch November 21, 2025 21:04
@6pac
Copy link
Owner

6pac commented Nov 22, 2025

Noting that the cell selection feature (ie. visible handle) should be available under either the cell selection or hybrid selection model. The hybrid selection model was introduced in the same PR as drag-fill, but they are not related. Really, the cell drag handle should be visible in either the cell selection model, or when the hybrid selection model is in cell selection mode. Perhaps we need a default setting to enable/disable drag-select.

@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Nov 22, 2025

Noting that the cell selection feature (ie. visible handle) should be available under either the cell selection or hybrid selection model. The hybrid selection model was introduced in the same PR as drag-fill, but they are not related. Really, the cell drag handle should be visible in either the cell selection model, or when the hybrid selection model is in cell selection mode. Perhaps we need a default setting to enable/disable drag-select.

feel free to review that or improve it, but per some basic tests I've done, it really shouldn't appear at all when using Row Selection which was the main fix in this PR. Also I don't think that it works with the regular SlickCellSelectionModel, so I removed it for that one too

@6pac
Copy link
Owner

6pac commented Nov 23, 2025

OK, all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants