Skip to content

Add native JSON data type support, through a new adapter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2018

Conversation

64kramsystem
Copy link
Owner

This PR introduces the adapter Mysql2JsonAdapter, which adds native support for the JSON data type.

The most immediate consequences are:

  • the user doesn't need to specify anymore the JSON column data type;
  • dumping a schema now supports the JSON data type.

Closes #6.

@64kramsystem 64kramsystem added the enhancement New feature or request label Feb 12, 2018
@64kramsystem 64kramsystem self-assigned this Feb 12, 2018
@64kramsystem 64kramsystem force-pushed the native_json_data_type_support branch from 7cc03d1 to 556189d Compare February 12, 2018 13:28
@coveralls
Copy link

coveralls commented Feb 12, 2018

Pull Request Test Coverage Report for Build 63

  • 25 of 28 (89.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.6%) to 87.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/active_record/connection_adapters/mysql2_json_adapter.rb 22 25 88.0%
Totals Coverage Status
Change from base Build 61: 3.6%
Covered Lines: 49
Relevant Lines: 56

💛 - Coveralls

@64kramsystem 64kramsystem force-pushed the native_json_data_type_support branch 3 times, most recently from 8144b2c to 452348b Compare February 12, 2018 17:36
@64kramsystem 64kramsystem force-pushed the native_json_data_type_support branch from 452348b to 46bdfeb Compare February 12, 2018 17:57
Repository owner deleted a comment from coveralls Feb 12, 2018
Repository owner deleted a comment from coveralls Feb 12, 2018
@64kramsystem 64kramsystem merged commit 1d94f24 into master Feb 12, 2018
@64kramsystem 64kramsystem deleted the native_json_data_type_support branch February 12, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants