Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple-blue-roboto.json #64

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

JCarlosR
Copy link
Contributor

@JCarlosR JCarlosR commented Oct 1, 2020

New Stylesheet Submission:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other files using the same name as yours?
  • Have you filled in at least the required data for title, author, and stylesheet?
  • Is the value of stylesheet a full URL that is publicly accessible and renders an unminified, compiled CSS file?
  • Do your styles pass proper contrast for accessibility?
  • [] Have you included @media (prefers-reduced-motion: reduce) to remove animations on *,*::before,*::after?
  • [] Did you style the .skip-link?
  • Have you checked on a real mobile device to ensure your responsive design doesn't cause overlaps or overflow scrolling?

I think I missed 2 points. Are they mandatory?
Let me know if that's the case 😅.

@github-actions
Copy link

github-actions bot commented Oct 1, 2020

👋 Thanks for participating! I will review as soon as possible, usually within a few hours.

Watch for notifications as I may request some small changes to make sure this meets the guidelines.

In a few minutes, the Netlify process at the end of this PR will make a preview available. Look for the message "Deploy preview ready!" then click the "Details" link next to it to launch a preview of your styles. Make changes if needed, and comment if you do so I can re-deploy the preview. Note that the "sponsor footer" is not available to fully style, but you may fix any issues it causes to your layout.

Thanks again, I hope you learned something while making your stylesheet! 💫

@github-actions github-actions bot added stylesheet submission problem detected Bot has detected an potential problem with the submission labels Oct 1, 2020
@5t3ph
Copy link
Owner

5t3ph commented Oct 1, 2020

Hi @JCarlosR - since you've largely kept the default styles as the base, you got the skip link for free ;)

As for the prefers-reduced-motion you also inherited that from the base styles, but you need to extend it to include at least :after to also remove the animation from the nav on hover 👍

I like this minimal update and the subtle animation and color changes!

@JCarlosR
Copy link
Contributor Author

JCarlosR commented Oct 1, 2020

In DevTools, using Ctrl+Shift+P and typing "reduce" it is possible to emulate the preference. Now I understand what this prefers-reduced-motion: reduce does.

You are right, I cloned your stylestage-sass repository and was able to use the hot reloading.

At the beginning I cloned the stylestage and endeded up generating screenshots, but then I noticed the other repository was one of the suggested starting points.

Thank you for the feedback.

I just pushed a new commit. The URL for the CSS file is the same, as this is pointing to the main branch and not to a specific commit.
Let me know if there is something else needed from my side.

Copy link
Owner

@5t3ph 5t3ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Thank you for participating! If you haven't already, consider subscribing for updates to learn about new styles and features: https://stylestage.dev/subscribe/

@5t3ph 5t3ph merged commit 219203c into 5t3ph:main Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem detected Bot has detected an potential problem with the submission stylesheet submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants