Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terrain type options to Natural Explorer features #794

Merged

Conversation

Dreaming-Codes
Copy link
Contributor

Summary

  • Added feature_specific field with terrain_type_options to natural-explorer-1-terrain-type, natural-explorer-2-terrain-types, and natural-explorer-3-terrain-types features
  • Used string type in options as discussed in issue natural-explorer-1-terrain-type missing choices #790
  • Fixed ranger natural explorer terrain type choices

Closes #790

Added feature_specific field with terrain_type_options to natural-explorer-1-terrain-type, natural-explorer-2-terrain-types, and natural-explorer-3-terrain-types features. This implements the functionality requested in issue #790.
@Dreaming-Codes Dreaming-Codes changed the title Add terrain type options to Natural Explorer features feat: add terrain type options to Natural Explorer features Mar 18, 2025
Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Once you get the API types and schemas updated, we can merge this in!

@bagelbits bagelbits merged commit d2620b8 into 5e-bits:main Mar 18, 2025
9 of 10 checks passed
Copy link

🎉 This PR is included in version 3.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Dreaming-Codes Dreaming-Codes deleted the fix/natural-explorer-terrain-options branch March 19, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

natural-explorer-1-terrain-type missing choices
2 participants