Skip to content

Issue #466: Change photo circles colors to represent party #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

raysj9
Copy link
Contributor

@raysj9 raysj9 commented Apr 4, 2025

  • Addresses Change photo circles colors to represent party #466
  • When a photo does not load or is unavailable, the respective party color is displayed instead of the sample colors.
  • If no party information is available, the fallback remains the sample colors.
  • Used soft tones of red, blue, and purple to match the aesthetic of the sample colors, but this can be changed if needed.
contact.color.change.mp4

Example of person with no party affiliation.

Copy link
Member

@nickoneill nickoneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Any chance you want to take a look at #465 too? This is a good fallback but honestly it shouldn't happen as frequently as it does

@raysj9
Copy link
Contributor Author

raysj9 commented Apr 6, 2025

@nickoneill Agreed. I'll take a look

@nickoneill nickoneill merged commit 918b9e2 into 5calls:main Apr 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants