Skip to content

Replace Union Types in method parameters list with type check (temporarily) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 27, 2021
Merged

Replace Union Types in method parameters list with type check (temporarily) #57

merged 8 commits into from
Dec 27, 2021

Conversation

mechelon
Copy link
Member

@mechelon mechelon commented Dec 22, 2021 •
edited
Loading

See #51

@mechelon
#51: Removed union types in method parameters (temporarily for PHP 7.…
bb16849 
…4 support) and replaced them with corresponding type check; added tests
@mechelon
Apply fixes from StyleCI (#56)
facedae
@mechelon mechelon changed the base branch from main to dev December 22, 2021 17:55
@mechelon mechelon requested a review from johguentner December 22, 2021 17:59
johguentner
johguentner approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@johguentner johguentner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one small thrown exception-text everything looks good to me !
Lets ship 🚀

@mechelon mechelon merged commit 3f873e5 into dev Dec 27, 2021
@mechelon mechelon deleted the fix/remove-union-types branch June 17, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johguentner johguentner johguentner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mechelon @johguentner