Skip to content

use Support\Collection instead of Eloquent\Collection #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

blessingefkt
Copy link
Contributor

While using this library in a non-laravel project, I hit an exception and realized this file is the only one referencing Illuminate\Database\Eloquent\Collection.

These are some details on the version I'm running:

 [
      'pretty_version' => 'v0.6.1',
      'version' => '0.6.1.0',
      'reference' => '973b1545c73beb34aae6a60dfac7581247e88671',
    ],

johguentner and others added 2 commits October 18, 2021 21:58
Patch for typo, type-check, removing unused file and block-update-functionality
While using this library in a non-laravel project, I hit an exception and realized this file is the only one referencing Illuminate\Database\Eloquent\Collection.

These are some details on the version I'm running:
```
 [
      'pretty_version' => 'v0.6.1',
      'version' => '0.6.1.0',
      'reference' => '973b1545c73beb34aae6a60dfac7581247e88671',
    ],
```
@mechelon mechelon changed the base branch from main to dev November 1, 2021 10:46
@mechelon
Copy link
Member

mechelon commented Nov 1, 2021

Thank you @blessingefkt! I will merge this into dev and we will release a patch as soon as possible.

@mechelon mechelon merged commit 0a54f93 into 5am-code:dev Nov 1, 2021
@blessingefkt blessingefkt deleted the patch-1 branch November 3, 2021 04:47
@mechelon mechelon mentioned this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants