Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix #409: Can't execute transactions that has more confirmations than required #437

Merged
merged 6 commits into from
Jan 16, 2020
Merged

Fix #409: Can't execute transactions that has more confirmations than required #437

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ddd174
Development (#378)
germartinez Dec 18, 2019
34aacb7
Merge branch 'development' of https://github.com/gnosis/safe-react
Agupane Dec 18, 2019
c4f39a4
Merge branch 'development' of https://github.com/gnosis/safe-react in…
Agupane Dec 26, 2019
62fdb46
Change check of confirmations size
Agupane Jan 14, 2020
a2ba1b3
Fix flags for execute transactions
Agupane Jan 14, 2020
386e117
Refactor variable isTheTxReadyToBeExecuted
Agupane Jan 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change check of confirmations size
  • Loading branch information
@Agupane
Agupane committed Jan 14, 2020
commit 62fdb462d74f5c0f40cf73d4b1c16b35d3ce41b8
2 changes: 1 addition & 1 deletion src/routes/safe/components/Transactions/TxsTable/ExpandedTx/ApproveTxModal/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const ApproveTxModal = ({
const [approveAndExecute, setApproveAndExecute] = useState<boolean>(canExecute)
const [gasCosts, setGasCosts] = useState<string>('< 0.001')
const { title, description } = getModalTitleAndDescription(thresholdReached)
const oneConfirmationLeft = !thresholdReached && tx.confirmations.size + 1 === threshold
const oneConfirmationLeft = !thresholdReached && tx.confirmations.size + 1 >= threshold

useEffect(() => {
let isCurrent = true
Expand Down