-
Notifications
You must be signed in to change notification settings - Fork 365
fix: throttle balance syncer + remove WC patch #3848
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
import { ChainId } from 'src/config/chain' | ||
import { getWCWalletInterface, getWalletConnectProvider } from 'src/logic/wallets/walletConnect/utils' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic was originally abstracted as it was used in the patched WC module as well as here.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 2262846367
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a deja vu :)
Have you tested it with different chains?
I have indeed. |
Connected to WC and there is no eth_getBalance at all, not even at the beggining, but that's the way is already in dev, so I assume is a normal behavior The only 2 networks with trez and ledger connection are Ethereum and rinkeby (the ones we have at least). It works the same in both of them. Looks good to me |
What it solves
Resolves
eth_getBalance
over-polling.How this PR fixes it
Onboard's balance state syncer has been throttled from every 1s to every 1h. As such, the patched WC module has also been reverted to the default.
How to test it
eth_getBalance
over-polling.