Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: hardware wallet console errors #3799

Merged
merged 2 commits into from
Apr 22, 2022
Merged

fix: hardware wallet console errors #3799

merged 2 commits into from
Apr 22, 2022

Conversation

iamacook
Copy link
Member

What it solves

Resolves #3762

How this PR fixes it

As hardware wallets cannot themselves change network, shouldSwitchNetwork now returns false when they are detected.

How to test it

Open the wallet connection modal and choose Ledger/Trezor. Observe no error in the console.

Screenshots

hwwarning

@iamacook iamacook requested a review from usame-algan April 20, 2022 11:18
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2195342461

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 35.573%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/logic/wallets/utils/network.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 2195129238: 0.02%
Covered Lines: 3554
Relevant Lines: 9043

💛 - Coveralls

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@francovenica
Copy link
Contributor

Look goods. No errors when connecting with trezor and ledger.

@iamacook iamacook merged commit d4e305a into dev Apr 22, 2022
@iamacook iamacook deleted the hw-wallet-console-error branch April 22, 2022 06:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in console when trying to connect with trezor or ledger
4 participants