This repository was archived by the owner on Nov 10, 2023. It is now read-only.
fix: Avoid showing ThirdPartyApp message for the cookies warning flow #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1986313656
💛 - Coveralls |
iamacook
approved these changes
Mar 15, 2022
| @@ -112,9 +113,10 @@ const useIframeMessageHandler = ( | |||
| data: SDKMessageToPayload[SDKMessageIds] | |||
| }>, | |||
| ) => { | |||
| if (message.origin === window.origin) { | |||
| if (message.origin === window.origin || message.origin === THIRD_PARTY_COOKIES_CHECK_URL) { | |||
There was a problem hiding this comment.
Stylistic, but you can simplify this:
Suggested change
| if (message.origin === window.origin || message.origin === THIRD_PARTY_COOKIES_CHECK_URL) { | |
| if ([window.origin, THIRD_PARTY_COOKIES_CHECK_URL].includes(message.origin)) { |
mmv08
approved these changes
Mar 15, 2022
|
Magnifico. Thank you Yago ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves safe-global/safe-react-apps#383
How this PR fixes it
By adding a condition to not show the message when the origin is the iframe validating the third party cookies activation
How to test it