feat: improve analytics #3415

iamacook · 2022-02-02T16:21:47Z

What it solves

Resolves #3408

How this PR fixes it

Google Tag Manager implementation
Update cookie banner to load GTM (fix: load GTM from cookie banner #3417)
Create tracking HoC (feat: create Track HoC #3421)
Anonymous tracking (fix: migrate anonymous page tracking to GTM #3426)
Removal of GA (fix: remove GA #3613)
Top-level tracking (fix: top-level tracking #3659)

Events

Safe creation/load (feat: track create/load Safe #3553)
Safe 'overview' ([Analytics] Track overview layout #3606)
All requested events (fix: track all events #3675)

How to test

Open the Safe and observe the the GTM script only injects when the analytics cookie checkbox is accepted
Open the Safe in GTM preview
Observe tracking of Safe creation/loading and overview according to the first two sections here in the console info

github-actions · 2022-02-02T16:22:02Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2022-02-02T16:24:43Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

coveralls · 2022-02-02T16:30:48Z

Pull Request Test Coverage Report for Build 2035146110

111 of 205 (54.15%) changed or added relevant lines in 54 files are covered.
24 unchanged lines in 13 files lost coverage.
Overall coverage increased (+0.4%) to 35.516%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/components/AppLayout/Header/components/NetworkSelector.tsx	0	1	0.0%
src/components/CookiesBanner/index.tsx	0	1	0.0%
src/components/SafeListSidebar/index.tsx	0	1	0.0%
src/logic/wallets/onboard.ts	0	1	0.0%
src/routes/LoadSafePage/steps/LoadSafeAddressStep.tsx	4	5	80.0%
src/routes/index.tsx	0	1	0.0%
src/routes/safe/components/AddressBook/EllipsisTransactionDetails/index.tsx	0	1	0.0%
src/routes/safe/components/AddressBook/ImportEntriesModal/index.tsx	0	1	0.0%
src/routes/safe/components/Apps/components/AddAppForm/index.tsx	0	1	0.0%
src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/components/SafeListSidebar/index.tsx	1	0%
src/components/SafeListSidebar/SafeList/index.tsx	1	0%
src/routes/safe/components/AddressBook/EllipsisTransactionDetails/index.tsx	1	10.0%
src/routes/safe/components/AddressBook/index.tsx	1	0%
src/routes/safe/components/Apps/components/AppFrame.tsx	1	0%
src/routes/safe/components/Balances/SendModal/screens/ReviewSendFundsTx/index.tsx	1	0%
src/routes/safe/components/Settings/ThresholdSettings/ChangeThreshold/index.tsx	1	0%
src/routes/safe/components/Settings/Appearance/index.tsx	2	0%
src/routes/safe/components/Settings/SafeDetails/index.tsx	2	0%
src/routes/safe/components/Transactions/TxList/hooks/useActionButtonsHandlers.ts	2	1.82%

Totals
Change from base Build 2027159306:	0.4%
Covered Lines:	3465
Relevant Lines:	8832

💛 - Coveralls

github-actions · 2022-02-02T16:33:34Z

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain

github-actions · 2022-02-02T16:39:58Z

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1958353835

Failed tests:

❌ Add an existing safe Add an existing safe
❌ Read-only transaction creation and review Read-only transaction creation and review
❌ Safe Apps List Safe Apps List

* fix: load GTM from cookie banner * fix: GTM env init check

* feat: create `Track` HoC * fix: remove unnecessary `undefined` check * fix: prop names/type tweak + conditional payload * fix: short props, throw when Fragment + add tests * fix: rename file extension

* fix: migrate pageview tracking to GTM * fix: cleanup event emission

* fix: add chain data to tracking + cross-env tests * fix: separate chain data from payload * fix: track `shortName` instead of `chainName`

github-actions · 2022-02-16T11:53:55Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2022-03-01T12:58:47Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	3	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

* feat: track create/load Safe steppers * fix: payload tracking in Safe create/load * fix: Track Safe creation events * fix: rename event + remove unnecessary var * fix: payload test Co-authored-by: Usame Algan <usame.algan@gnosis.pm>

* feat: track create/load Safe steppers * fix: payload tracking in Safe create/load * fix: Track Safe creation events * fix: rename event + remove unnecessary var * fix: payload test * wrap overview buttons with <Track /> HOC * fix: Adjust structure of dataLayer object for trackEvent call * refactor: Extract track variables * chore: Revert method name refactor * refactor: Move safe overview tags to its own file * feat: Add tracking to currency change, intercom and help center * fix: Remove spreads where possible * fix: failing test Co-authored-by: iamacook <aaron.cook@gnosis.pm> Co-authored-by: Usame Algan <usame.algan@gnosis.pm>

* fix: remove GA * fix: remove GA from test

iamacook · 2022-03-03T12:06:15Z

@johannesmoormann, it seems as though GTM doesn't have any cookies. Do we need to include it conditionally based on the cookie selection? It currently loads according to the choice made by the user. I can't confirm if, after implementing funnels in GA, that cookies will then appear though.

What do you think?

* fix: top level tracking + unload tracking * fix: use shorthand * fix: add dependency * fix: tracking events * fix: track via listener * fix: `waitFor` event listener * fix: lint * fix: add GA `eventValue` + centralise events * fix: cleanup * fix: `currentStep` as value * fix: remove `eventValue` + less verbose events * fix: add dependency * fix: use ref in variable * fix: test * fix: check that GTM is loaded + remove comment * fix: return early * fix: track all events (#3675) * fix: add legacy events * fix: incorrect events * fix: remove unnecessary dependencies * feat: add new tracking events * fix: test * fix: memoize tracking + always init GTM * fix: spending limit tracking label * fix: rm `navigation` category + rm `pageview` vars * fix: remove memoization * fix: track wallet, (un-)pin/named Safe Apps, App click * fix: use campaign link for iPhone app

github-actions · 2022-03-21T13:38:06Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	3	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

* fix: events + don't trigger GA on dev env * fix: remove dev flag from events * fix: only track changing `pathname` * fix: don't cache anonymised path

katspaugh

🚀

feat: add Google Tag Manager

3f85818

iamacook added 2 commits February 2, 2022 17:57

fix: load GTM from cookie banner (#3417)

11960ae

* fix: load GTM from cookie banner * fix: GTM env init check

fix: move gtm dev env to env var

51bee73

katspaugh added the Epic label Feb 3, 2022

iamacook added 4 commits February 3, 2022 13:14

feat: create Track HoC (#3421)

5dd709d

* feat: create `Track` HoC * fix: remove unnecessary `undefined` check * fix: prop names/type tweak + conditional payload * fix: short props, throw when Fragment + add tests * fix: rename file extension

fix: migrate anonymous page tracking to GTM (#3426)

bee065e

* fix: migrate pageview tracking to GTM * fix: cleanup event emission

Merge branch 'dev' into improve-analytics

bcce0fd

fix: add chain data to tracking (#3523)

f88b7e6

* fix: add chain data to tracking + cross-env tests * fix: separate chain data from payload * fix: track `shortName` instead of `chainName`

iamacook added 3 commits February 17, 2022 16:24

Merge branch 'dev' into improve-analytics

6ea625e

Merge branch 'dev' into improve-analytics

68f5c08

Merge branch 'dev' into improve-analytics

7e69ae5

feat: track create/load Safe (#3553)

44daa36

* feat: track create/load Safe steppers * fix: payload tracking in Safe create/load * fix: Track Safe creation events * fix: rename event + remove unnecessary var * fix: payload test Co-authored-by: Usame Algan <usame.algan@gnosis.pm>

iamacook temporarily deployed to Manual March 2, 2022 11:00 Inactive

Merge branch 'dev' into improve-analytics

ad0daa7

iamacook temporarily deployed to Manual March 3, 2022 08:18 Inactive

iamacook temporarily deployed to Manual March 3, 2022 09:39 Inactive

fix: remove GA (#3613)

b7cbc03

* fix: remove GA * fix: remove GA from test

iamacook temporarily deployed to Manual March 3, 2022 11:56 Inactive

iamacook requested a review from usame-algan March 3, 2022 15:02

usame-algan approved these changes Mar 4, 2022

View reviewed changes

Merge branch 'dev' into improve-analytics

107f7f1

iamacook added 5 commits March 7, 2022 16:36

chore: add GTM env vars to deploy script

cf16a7e

Merge branch 'dev' into improve-analytics

045df1a

Merge branch 'dev' into improve-analytics

f69d942

Merge branch 'dev' into improve-analytics

68d0b09

katspaugh and others added 2 commits March 22, 2022 15:43

Merge branch 'dev' into improve-analytics

fed5f9f

fix: only log differeng tokens after fetch

9d60304

yagopv mentioned this pull request Mar 23, 2022

Uncertainty of which methods and versions are currently used on the Safe Apps SDK safe-global/safe-pm#47

Closed

fix: tweak events + don't trigger GA on dev (#3715)

1634663

* fix: events + don't trigger GA on dev env * fix: remove dev flag from events * fix: only track changing `pathname` * fix: don't cache anonymised path

katspaugh approved these changes Mar 24, 2022

View reviewed changes

Merge branch 'dev' into improve-analytics

ee52c4c

iamacook merged commit 5ec343f into dev Mar 24, 2022

iamacook deleted the improve-analytics branch March 24, 2022 15:28

github-actions bot locked and limited conversation to collaborators Mar 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve analytics #3415

feat: improve analytics #3415

iamacook commented Feb 2, 2022 •

edited

Loading

github-actions bot commented Feb 2, 2022

github-actions bot commented Feb 2, 2022 •

edited

Loading

coveralls commented Feb 2, 2022 •

edited

Loading

github-actions bot commented Feb 2, 2022

github-actions bot commented Feb 2, 2022 •

edited

Loading

github-actions bot commented Feb 16, 2022 •

edited

Loading

github-actions bot commented Mar 1, 2022 •

edited

Loading

iamacook commented Mar 3, 2022

github-actions bot commented Mar 21, 2022 •

edited

Loading

katspaugh left a comment

feat: improve analytics #3415

feat: improve analytics #3415

Conversation

iamacook commented Feb 2, 2022 • edited Loading

What it solves

How this PR fixes it

Events

How to test

github-actions bot commented Feb 2, 2022

github-actions bot commented Feb 2, 2022 • edited Loading

ESLint Summary View Full Report

coveralls commented Feb 2, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2035146110

💛 - Coveralls

github-actions bot commented Feb 2, 2022

Deployment links

github-actions bot commented Feb 2, 2022 • edited Loading

github-actions bot commented Feb 16, 2022 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Mar 1, 2022 • edited Loading

ESLint Summary View Full Report

iamacook commented Mar 3, 2022

github-actions bot commented Mar 21, 2022 • edited Loading

ESLint Summary View Full Report

katspaugh left a comment

Choose a reason for hiding this comment

iamacook commented Feb 2, 2022 •

edited

Loading

github-actions bot commented Feb 2, 2022 •

edited

Loading

coveralls commented Feb 2, 2022 •

edited

Loading

github-actions bot commented Feb 2, 2022 •

edited

Loading

github-actions bot commented Feb 16, 2022 •

edited

Loading

github-actions bot commented Mar 1, 2022 •

edited

Loading

github-actions bot commented Mar 21, 2022 •

edited

Loading