[Address Book] Use address book entries in Owner list

[leolower]

[Agupane]

Hi @lukasschor, I have a question:
Currently we are displaying the owner list on the transaction details using the names on the addressbook (in case the user has that address on it)
Like this:

This issue should also do the same with the owner list on settings, right?. In that case, what should happen with the "edit owner name" functionality of the settings page?, should update the addressbook?.

If the user does not have that owner on the addressbook, should we add it on the addressbook?

[lukasschor]

Yes ideally there is only one mapping that connects a given ethereum address with a human-readable name. No matter whether the address was introduced as an owner or just an address book entry.

So the address book should have the following entries by default:

• Owner names
• Safe name

As these should be treated like any other ethereum address. This also reduces the need for an empty state for newly created safes as the address book already includes at least the entries of one or more owners and the safe.

So coming back to your question, yes changing owner name should also modify the address book entry. Same for modify Safe name.

Does that all make sense?

[Agupane]

So if I understood correctly, an addressbook should be related to a safe, so multiples safes will have different addressbooks?. I thought that the addressbook should be global for all the safes.

[lukasschor]

Address book should be global. So if a user has

Safe 1 (Owner A & B)
Safe 2 (Owner C & D)

and creates

Safe 3 (Owner E & F)

The address book would at least have the entries for
Safes 1, 2 & 3
Owners A-F

If two safes have the same owner and the name is changed in one Safe it would have an effect on the owner name in the second safe.

The challenge is if a Safe is created with an Owner that already has a name associated or a Safe is loaded where the Safe address already has an entry in the address book. Ideally this would be detected in the create / load flows and the name is already added to the input field. But for now it would probably also be fine if the name given in the create/load flows just overwrites existing entries.

[Agupane]

Got it now, thanks!. Will get back to you in case something is needed :)

[Agupane]

@lukasschor should the users be able to remove an owner from the address book? or should the delete button be disabled?

[lukasschor]

It should probably be disabled