-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
134 dynamic gateway reconfiguration #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created new contracts for adding and deleting NetApp routes, Configured gateway for RabbitMQ consumers Added Documentation(WIP)
Artonus
requested changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radu-popescu, it looks mostly good to me. I have found a few minor changes to be made and it will be great!
accept changes Co-authored-by: Bartosz Bratuś <bartoszRyszard.bratus@beds.ac.uk>
…com/5G-ERA/middleware into 134-dynamic-gateway-reconfiguration
Co-authored-by: Bartosz Bratuś <bartoszRyszard.bratus@beds.ac.uk>
Co-authored-by: Bartosz Bratuś <bartoszRyszard.bratus@beds.ac.uk>
Artonus
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the RabbitMQ queueing system, this new feature offers the possibility to automatically reconfigure the gateway to route the traffic to the specific Network Application on demand.
Fixes #134
Type of change
What has been changed?
How Has This Been Tested?
Checklist: