Change the default image registry for the Middleware images #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artonus
added
documentation
|
bartos didnt understood ??
…________________________________
From: Bartosz Bratuś ***@***.***>
Sent: Thursday, April 13, 2023 3:47 PM
To: 5G-ERA/middleware ***@***.***>
Cc: Diwali Diwali ***@***.***>; Review requested ***@***.***>
Subject: [5G-ERA/middleware] Change the default image registry for the Middleware images (PR #137)
CAUTION: This email originated from outside of the University of Bedfordshire. Do not click links or open attachments unless you recognise the sender and know the content is safe.
Changed:
* Name of the environment variable that stores the image registry address
* Default value of the image registry now is ghcr.io/5g-era
* Installation instructions on how to deploy the 5G-ERA Middleware
________________________________
You can view, comment on, or merge this pull request online at:
#137
Commit Summary
* 51a34ea<51a34ea> Change the default image registry for the Middleware images
* bf4129e<bf4129e> Deployment instructions correction after making 5G-ERA images public
* a7351f4<a7351f4> ActionServer readme corrections
File Changes
(11 files<https://github.com/5G-ERA/middleware/pull/137/files>)
* M docs/Administrator/Actionserver.md<https://github.com/5G-ERA/middleware/pull/137/files#diff-80eea5086188555f697706d992a3157345b1fac76322742f24035df07776b5be> (33)
* M docs/Administrator/Middleware_Installation.md<https://github.com/5G-ERA/middleware/pull/137/files#diff-e0f051c5a8a822dc55dba33c7232187bbf42bb4061bd6ebcd56b52133f9b4ca8> (156)
* M docs/Administrator/readme.md<https://github.com/5G-ERA/middleware/pull/137/files#diff-2410180024813b2737091aecda748f23f111c679c6aeccf4ae4722999c64a11e> (1)
* M docs/Where_to_start/roadmap.md<https://github.com/5G-ERA/middleware/pull/137/files#diff-ed9b9908e8e3a00a2343836c9e8bfdd47cbc9088c01ed8ad7cb58211fe6b3377> (8)
* M k8s/central-api/central-api.yaml<https://github.com/5G-ERA/middleware/pull/137/files#diff-ab3910bf924a05a67b1a1621724c09a2cf20a2ec343fa6daa1c556a9475f6da6> (2)
* M k8s/gateway/gateway_deployment.yaml<https://github.com/5G-ERA/middleware/pull/137/files#diff-6ca4566b56070f664f6de7ea587d88a78774424d955236f91d20f2a0affdd6c2> (10)
* M k8s/orchestrator/orchestrator.yaml<https://github.com/5G-ERA/middleware/pull/137/files#diff-9fef80664c9dab6a3adef91cbd60761ba5d9880dcd098eddca3f03fc18762ea4> (42)
* M k8s/redis-interface/redis_interface_deployment.yaml<https://github.com/5G-ERA/middleware/pull/137/files#diff-85bb3072f21f74c83fc846154502be982c75e828916fe2a67522f2755713bb05> (20)
* M k8s/task-planner/task_planner_deployment.yaml<https://github.com/5G-ERA/middleware/pull/137/files#diff-2f0a0b634f2eb8e0f86b7073de42348fed22239f4790e7134a104cc0692ad1c9> (10)
* M src/Orchestrator/Deployment/DeploymentService.cs<https://github.com/5G-ERA/middleware/pull/137/files#diff-bd4554b0164363b65b46b5a4eff88ce29994ec07e7013432e95e1dc4c645bf4b> (74)
* M src/RedisInterface.Sdk/IRedisInterfaceClient.cs<https://github.com/5G-ERA/middleware/pull/137/files#diff-40d01cbbf0d62a6ca68e8ce9687fa0b6e9620c5383a1095774453ba27574277a> (8)
Patch Links:
* https://github.com/5G-ERA/middleware/pull/137.patch
* https://github.com/5G-ERA/middleware/pull/137.diff
—
Reply to this email directly, view it on GitHub<#137>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWIELFKVCRFROQWSTQ5Z3CDXBAGY7ANCNFSM6AAAAAAW5GGM7Y>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
There was a problem hiding this comment.
- ROS action goal is a specific protocol, the term protocol I am not sure is it accurate here, if it is then should we define what is ROS action goal protocol is.
- the last line " After the robot has finished the execution of the last element in the action sequence, a new goal will be issued with a distinct element to let the Middleware know that the overall high-level task was achieved successfully. This property is the action reference with value –1. When receiving this goal, the status of this goal will be changed to success in the state machine and the result call-back will be called" Should we make it bit more simpler. Other than that everything is fine.
@diwalipathak
Corrected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed:
ghcr.io/5g-era