Conversation
|
Thanks for the PR! I appreciate the work that went into modifying Pulley to support Objective-C, however the changes do break backwards compatibility and make using Pulley less intuitive for Swift users. As a result, I'm not going to merge these changes into the primary repo. I will leave the PR open (unless you choose to close it), so that anyone wanting to support Objective-C can find your branch. |
|
@Brendan09 I'm in the same situation as @cskaynar and would like to use this library in my ObjC project, but I also need access to that delegate. Do you have any guidelines about ways that I could add that support without breaking backwards compatibility? |
|
@CareerFairPlus Pulley uses an array of enums. Unfortunately, this is a Swift only feature. In order to remove it, this would have to be replaced with something that removes the type-safety this provides for Swift users. My recommendation would be to write the view controllers that need to be Pulley delegates in Swift. |
|
Thanks for the quick reply. I'll consider that, as I think I can encapsulate the delegate behavior without needing to move over any existing parts of our app to Swift. |
|
@CareerFairPlus Yeah, you should be able to do a view controller class in Swift that implements the delegate stuff, and then subclass that to do your view controller in Objective-C. |
No description provided.