Skip to content

Conversation

phiSgr
Copy link
Collaborator

@phiSgr phiSgr commented Oct 8, 2025

Note

Adds full stack support for ClickHouse geometry types (Point, Ring, LineString, MultiLineString, Polygon, MultiPolygon) across Rust core, TS/Python libs, codegen, ingestion/validation, docs, and e2e tests.

  • Core (Rust):
    • Add ColumnType variants: Point, Ring, LineString, MultiLineString, Polygon, MultiPolygon with serde/proto mapping and display.
    • Map to ClickHouse types in clickhouse/mapper.rs, model.rs, queries.rs; parse/convert in type_parser.rs.
    • Ingestion/validation: handle geo JSON shapes in kafka_clickhouse_sync.rs and validate_passthrough.rs; disallow in CSV import.
  • TypeScript Library:
    • New helper types: ClickHousePoint, ClickHouseRing, ClickHouseLineString, ClickHouseMultiLineString, ClickHousePolygon, ClickHouseMultiPolygon; export via index.ts.
    • Type conversion/validation for geometry in typeConvert.ts; TS codegen emits proper imports/types and interface shapes; defaults in streaming generator.
    • Generator interface support for nested tuple/array shapes of points.
  • Python Library:
    • New type aliases: Point, Ring, LineString, MultiLineString, Polygon, MultiPolygon with structural validation; integrate into py_type_to_column_type.
    • Python codegen imports geometry types.
  • Docs:
    • Add geometry types to supported types with TS/PY examples; remove "Geo types unsupported" notice in getting-started.
  • E2E/Tests:
    • Add GeoTypes table schema expectations (TS/PY) and ingestion tests for geometry via /ingest/GeoTypes and /ingest/geotypes.
    • Update protobuf SimpleColumnType with geometry entries.

Written by Cursor Bugbot for commit 442c835. This will update automatically on new commits. Configure here.

Copy link

linear bot commented Oct 8, 2025

Copy link

vercel bot commented Oct 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
framework-docs Ready Ready Preview Comment Oct 11, 2025 1:12am

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@phiSgr phiSgr requested a review from callicles October 9, 2025 23:33
],
})),
)))),
))),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: TypeScript Generator Outputs Incorrect Point Types

The TypeScript generator creates Point geometry types as an object interface with string keys "0" and "1" instead of a tuple [number, number]. This leads to a type mismatch with actual data and an inconsistent API for geometry coordinates.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants