-
Notifications
You must be signed in to change notification settings - Fork 19
Add Boreal version detection documentation for Python and TypeScript #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: jmsuzuki <2999398+jmsuzuki@users.noreply.github.com>
Co-authored-by: jmsuzuki <2999398+jmsuzuki@users.noreply.github.com>
Co-authored-by: jmsuzuki <2999398+jmsuzuki@users.noreply.github.com>
|
||
return mooseVerRequirement; | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not provide code blocks. provide the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the JavaScript code blocks and replaced them with logical flow descriptions. The documentation now explains the version detection process without exposing implementation details. Commit af38659
…scriptions Co-authored-by: jmsuzuki <2999398+jmsuzuki@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge an iterate
This PR adds comprehensive documentation explaining how Moose versions are determined in Boreal cloud deployments for both Python and TypeScript projects.
Changes Made
/moose/deploying/boreal
section with detailed version detection logicTypeScript Detection Logic
Shows how Boreal looks for
@514labs/moose-lib
version with fallback priority:Python Detection Logic
Documents how Boreal searches for
moose_lib
version in:The documentation includes the actual implementation code from the issue description, making it clear to developers how version compatibility is automatically managed during Boreal deployments.
Fixes #2465.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.