Skip to content

feat(offline): union query #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat(offline): union query #3653

merged 1 commit into from
Dec 7, 2023

Conversation

aceforeverd
Copy link
Collaborator

UNION query for offline, based on #3590 , supports UNION ALL and UNION DISTINCT

@github-actions github-actions bot added batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Dec 1, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a8c0226) 40.16% compared to head (f28842b) 74.94%.

Files Patch % Lines
...radigm/openmldb/batch/nodes/SetOperationPlan.scala 68.75% 5 Missing ⚠️
hybridse/src/vm/runner_builder.cc 40.00% 3 Missing ⚠️
hybridse/src/vm/physical_op.cc 50.00% 1 Missing ⚠️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #3653       +/-   ##
=============================================
+ Coverage     40.16%   74.94%   +34.77%     
  Complexity      640      640               
=============================================
  Files           191      725      +534     
  Lines         11233   130788   +119555     
  Branches       1325     1344       +19     
=============================================
+ Hits           4512    98020    +93508     
- Misses         6428    32475    +26047     
  Partials        293      293

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd force-pushed the feat-offline-union-query branch from 9b2abeb to f28842b Compare December 5, 2023 06:58
@github-actions github-actions bot removed the storage-engine openmldb storage engine. nameserver & tablet label Dec 5, 2023
tobegit3hub
tobegit3hub approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit d4f6346 into 4paradigm:main Dec 7, 2023
@aceforeverd aceforeverd deleted the feat-offline-union-query branch December 7, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobegit3hub tobegit3hub tobegit3hub approved these changes

@dl239 dl239 dl239 approved these changes

@vagetablechicken vagetablechicken Awaiting requested review from vagetablechicken

@lqy222 lqy222 Awaiting requested review from lqy222

Assignees
No one assigned
Labels
batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aceforeverd @tobegit3hub @dl239