Skip to content

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Nov 29, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the sdk openmldb java/python sdk label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (5e225da) 40.16% compared to head (7ad6ea1) 40.16%.
Report is 4 commits behind head on main.

Files Patch % Lines
...java/com/_4paradigm/openmldb/sdk/SqlException.java 0.00% 4 Missing ⚠️
...paradigm/openmldb/sdk/impl/SqlClusterExecutor.java 63.63% 3 Missing and 1 partial ⚠️
.../com/_4paradigm/openmldb/spark/OpenmldbSource.java 0.00% 1 Missing ⚠️
...openmldb/spark/write/OpenmldbDataSingleWriter.java 0.00% 1 Missing ⚠️
...adigm/openmldb/spark/write/OpenmldbDataWriter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3642      +/-   ##
============================================
- Coverage     40.16%   40.16%   -0.01%     
- Complexity      640      642       +2     
============================================
  Files           191      191              
  Lines         11233    11244      +11     
  Branches       1325     1326       +1     
============================================
+ Hits           4512     4516       +4     
- Misses         6428     6435       +7     
  Partials        293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit e540195 into 4paradigm:main Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adding one more zk client makes zk cxns exhausted easily
4 participants