Skip to content

feat: use user sync timeout when it > default #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2023
Merged

feat: use user sync timeout when it > default #3484

merged 3 commits into from
Sep 8, 2023

Conversation

vagetablechicken
Copy link
Collaborator

closes #3482

@github-actions github-actions bot added documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet labels Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (badf7ab) 75.37% compared to head (eff3e85) 75.38%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3484      +/-   ##
============================================
+ Coverage     75.37%   75.38%   +0.01%     
  Complexity      414      414              
============================================
  Files           707      707              
  Lines        128561   128637      +76     
  Branches       1191     1191              
============================================
+ Hits          96900    96971      +71     
- Misses        31420    31425       +5     
  Partials        241      241
Files Changed Coverage Δ
src/sdk/sql_cluster_router.cc 61.81% <100.00%> (+0.02%) ⬆️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dl239
dl239 reviewed Sep 6, 2023
View reviewed changes
@vagetablechicken vagetablechicken merged commit b7d6edc into 4paradigm:main Sep 8, 2023
@vagetablechicken vagetablechicken deleted the i3482 branch September 8, 2023 05:07
dl239 pushed a commit that referenced this pull request Sep 19, 2023
@vagetablechicken @dl239
feat: use user sync timeout when it > default (#3484)
4625b31 
* feat: use user sync timeout when it > default

* fix doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dl239 dl239 dl239 approved these changes

@aceforeverd aceforeverd aceforeverd approved these changes

@tobegit3hub tobegit3hub Awaiting requested review from tobegit3hub

@lqy222 lqy222 Awaiting requested review from lqy222

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

offline sync job timeout improvement
3 participants
@vagetablechicken @dl239 @aceforeverd