Skip to content

Conversation

vagetablechicken
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.45 ⚠️

Comparison is base (b3f57ae) 79.05% compared to head (0a1a5e5) 75.61%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3251      +/-   ##
============================================
- Coverage     79.05%   75.61%   -3.45%     
- Complexity        0      393     +393     
============================================
  Files           520      681     +161     
  Lines        116256   125643    +9387     
  Branches          0     1181    +1181     
============================================
+ Hits          91906    95000    +3094     
- Misses        24334    30407    +6073     
- Partials         16      236     +220     
Impacted Files Coverage Δ
src/nameserver/name_server_impl.cc 44.68% <0.00%> (-0.19%) ⬇️
src/zk/dist_lock.cc 83.33% <0.00%> (+1.51%) ⬆️

... and 175 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub removed the request for review from dl239 May 8, 2023 06:59
@tobegit3hub tobegit3hub merged commit 904a3f7 into 4paradigm:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants