Skip to content

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Apr 28, 2023

if we deploy a SQL contains LAST JOIN, kLatestTime index is required. if there is another index type like kAbsoluteTIme, it will deploy failed. So we add skip_index_check option to skip index checking

@dl239 dl239 changed the title feat: add skip_index_check option feat: add skip_index_check option Apr 28, 2023
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ff3a355) 75.61% compared to head (d02ef6d) 75.61%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3241   +/-   ##
=========================================
  Coverage     75.61%   75.61%           
  Complexity      393      393           
=========================================
  Files           681      681           
  Lines        125633   125671   +38     
  Branches       1181     1181           
=========================================
+ Hits          94996    95030   +34     
- Misses        30401    30405    +4     
  Partials        236      236           
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
src/cmd/sql_cmd_test.cc 99.14% <100.00%> (+0.01%) ⬆️
src/sdk/sql_cluster_router.cc 62.83% <100.00%> (+0.14%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 4, 2023
@lqy222 lqy222 mentioned this pull request May 8, 2023
@dl239 dl239 requested review from tobegit3hub and aceforeverd May 9, 2023 09:48
@dl239 dl239 enabled auto-merge (squash) May 9, 2023 09:49
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 73cd33a into 4paradigm:main May 9, 2023
@dl239 dl239 deleted the feat/deploy-option branch May 9, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants