feat: fix duplicated code in taskmanager k8s manager #3185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dl239
approved these changes
Apr 4, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3185 +/- ##
=============================================
- Coverage 81.48% 75.66% -5.82%
- Complexity 0 393 +393
=============================================
Files 8 677 +669
Lines 578 125363 +124785
Branches 0 1180 +1180
=============================================
+ Hits 471 94861 +94390
- Misses 91 30266 +30175
- Partials 16 236 +220
... and 668 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
vagetablechicken
approved these changes
Apr 4, 2023
aceforeverd
approved these changes
Apr 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve build issue of https://github.com/4paradigm/OpenMLDB/actions/runs/4592622057/jobs/8109810936 .