Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support between predicate #277

Merged
merged 9 commits into from
Aug 24, 2021

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Aug 18, 2021

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #226

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2021

Linux Test Report

     48 files  ±0     121 suites  ±0   36m 17s ⏱️ ±0s
7 959 tests ±0  7 957 ✔️ ±0  0 💤 ±0  2 ❌ ±0 
7 963 runs  ±0  7 961 ✔️ ±0  0 💤 ±0  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 8a30132. ± Comparison against base commit 8a30132.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #277 (ad5332d) into main (20a8c50) will increase coverage by 0.12%.
The diff coverage is 98.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #277      +/-   ##
============================================
+ Coverage     81.77%   81.90%   +0.12%     
  Complexity       13       13              
============================================
  Files           283      283              
  Lines         50417    50545     +128     
  Branches         29       29              
============================================
+ Hits          41230    41399     +169     
+ Misses         9178     9137      -41     
  Partials          9        9              
Impacted Files Coverage Δ
hybridse/src/codegen/expr_ir_builder.h 100.00% <ø> (ø)
...ybridse/src/passes/physical/condition_optimized.cc 80.25% <ø> (+3.18%) ⬆️
...e/src/passes/physical/transform_up_physical_pass.h 25.00% <ø> (ø)
hybridse/src/udf/default_udf_library.cc 96.04% <ø> (ø)
hybridse/src/node/sql_node.cc 76.84% <84.61%> (+0.66%) ⬆️
hybridse/include/node/sql_node.h 69.83% <100.00%> (+0.51%) ⬆️
hybridse/src/codegen/expr_ir_builder.cc 70.84% <100.00%> (+0.63%) ⬆️
hybridse/src/codegen/expr_ir_builder_test.cc 98.05% <100.00%> (+0.17%) ⬆️
hybridse/src/codegen/predicate_expr_ir_builder.cc 74.06% <100.00%> (+0.68%) ⬆️
...idse/src/codegen/predicate_expr_ir_builder_test.cc 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a8c50...ad5332d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2021

HybridSE Linux Test Report

       71 files  ±0       220 suites  ±0   5m 15s ⏱️ ±0s
18 036 tests ±0  18 036 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
18 043 runs  ±0  18 043 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8a30132. ± Comparison against base commit 8a30132.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2021

HybridSE Mac Test Report

       71 files  ±0       220 suites  ±0   5m 46s ⏱️ ±0s
18 036 tests ±0  18 036 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
18 043 runs  ±0  18 043 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8a30132. ± Comparison against base commit 8a30132.

♻️ This comment has been updated with latest results.

@imotai imotai self-requested a review August 23, 2021 13:36
Copy link
Collaborator

@jingchen2222 jingchen2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 8a30132 into 4paradigm:main Aug 24, 2021
@aceforeverd aceforeverd deleted the feat/226-between-and-expr branch December 10, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: support between predicate
3 participants